#26893 closed defect (fixed)

spec: all-zeroes special case is for relay IDs, not cell digests

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, fast-fix, prop295-assigned-sponsor-v
Cc: Actual Points:
Parent ID: #26869 Points:
Reviewer: teor Sponsor: SponsorV

Description

tor-spec.txt Section 5.3 (Creating circuits) says:

   As special cases, if the extend cell includes a digest of
   all zeroes, or asks to extend back to the relay that sent the extend

The implementation uses "digest" internally to refer to relay ID hashes, while tor-spec.txt primarily uses it to refer to the truncated running SHA-1 hash that relays use to "recognize" a cell as targeting them.

arma says this probably intends to refer to relay ID hashes, and pointed to commit e34727a65c411a6260f3960ff8a753088e287565.

We should reword this text to make it clear it refers to relay ID hashes.

Child Tickets

Change History (6)

comment:1 Changed 15 months ago by catalyst

Summary: all-zeroes special case is for relay IDs, not cell digestsspec: all-zeroes special case is for relay IDs, not cell digests

comment:2 Changed 15 months ago by catalyst

Status: newneeds_review

comment:3 Changed 15 months ago by asn

Reviewer: teor

comment:4 Changed 15 months ago by teor

Parent ID: #26869
Status: needs_reviewmerge_ready

We found this issue during the prop#295 review.

The new text looks fine to me.

comment:5 Changed 15 months ago by teor

Keywords: prop295-assigned-sponsor-v added
Sponsor: SponsorV

I think all prop#295 tickets are sponsor V.

comment:6 Changed 15 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.