Opened 2 years ago

Closed 2 years ago

#26894 closed defect (fixed)

spec: say CREATE/CREATE2 and EXTEND/EXTEND2 when we mean to

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, fast-fix, prop295-assigned-sponsor-v
Cc: Actual Points:
Parent ID: #26869 Points:
Reviewer: teor Sponsor: SponsorV


In several places in tor-spec.txt, it looks like we say only CREATE or EXTEND when we really mean to also include CREATE2 or EXTEND2. We should fix those.

Child Tickets

Change History (6)

comment:1 Changed 2 years ago by catalyst

Status: newneeds_review

comment:2 Changed 2 years ago by asn

Reviewer: teor

comment:3 Changed 2 years ago by teor

Cc: #26869 added
Status: needs_reviewmerge_ready

We found this issue during the prop#295 review.

The new commits look good to me.
(I feel like I wrote a patch like this, but I can't find it, and yours looks better anyway.)

comment:4 Changed 2 years ago by teor

Cc: #26869 removed
Parent ID: #26869

comment:5 Changed 2 years ago by teor

Keywords: prop295-assigned-sponsor-v added
Sponsor: SponsorV

I think all prop#295 tickets are sponsor V.

comment:6 Changed 2 years ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged along with #26893

Note: See TracTickets for help on using tickets.