Opened 15 months ago

Last modified 14 months ago

#26895 needs_information defect

'Error downloading build result' after GCC in container Tor Browser Bundle Build (rbm)... most descriptive error ever ocurred in the world

Reported by: kfseaperson Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

$ make
git submodule update --init
./rbm/rbm build release --target release --target torbrowser-all
Building project tor-browser - tor-browser-8.0a9-linux-x86_64-58eca3
Using file out/container-image/container-image_wheezy-amd64-df3a332e7b34.tar.gz
Building project firefox - firefox-a0efd2fcd6e9-linux-x86_64-0974b5
Tag tor-browser-60.1.0esr-8.0-1-build2 is signed with key 35CD74C24A9B15A19E1A81A194373AA94B7C3223
Created tmp/rbm-mgl5M/firefox-a0efd2fcd6e9.tar.gz
Using file out/container-image/container-image_wheezy-amd64-279bd3a261cd.tar.gz
Building project gcc - gcc-6.4.0-3098e6.tar.gz
Using file out/container-image/container-image_wheezy-amd64-2bf0a6561acb.tar.gz
Using file out/gcc/gcc-6.4.0.tar.xz
[sudo] password for $USER:
Build log: logs/gcc-linux-x86_64.log
[sudo] password for $USER:
Error: Error downloading build result
make: * [Makefile:6: release] Error 1

Thats the log on the screen...

Child Tickets

Attachments (1)

log.zip (486.0 KB) - added by kfseaperson 15 months ago.
gcc log (zipped to reduce file size)

Download all attachments as: .zip

Change History (11)

Changed 15 months ago by kfseaperson

Attachment: log.zip added

gcc log (zipped to reduce file size)

comment:1 Changed 15 months ago by boklm

Component: Applications/rbmApplications/Tor Browser
Owner: changed from boklm to tbb-team
Status: newneeds_information

Some questions to help understand the problem:

  • what OS are you using?
  • did you manage do finish some build before and this is a new error, or do you get this error on the first try?

comment:2 Changed 15 months ago by kfseaperson

Linux
If I remember well I have the approximately same thing on different linux distro
Currently I got it working but after modified something so I don't know if that caused it

did you manage do finish some build before and this is a new error, or do you get this error on the first try?

Not on this machine
not the first try but about 3rd and so on

comment:3 in reply to:  2 Changed 15 months ago by boklm

Replying to kfseaperson:

Linux

Which Linux distribution are you using?

If I remember well I have the approximately same thing on different linux distro
Currently I got it working but after modified something so I don't know if that caused it

What did you modify?

comment:4 Changed 15 months ago by kfseaperson

I commented the rm -Rf $remote_tmp_src $remote_tmp_dst (run_script@rbm/lib/RBM.pm) out after it is done with something
so I would be weird if that have much effect, but not sure
currently I use arch but don't know how that would help you further

comment:5 Changed 15 months ago by boklm

so I would be weird if that have much effect, but not sure

It's difficult to say without seeing the exact changes that were done. It's also possible that some other change or update on your system fixed the issue.

Can you provide the full logs of the error you get when you do a build from a completely clean git clone, from current master commit?

  • without any modification to rbm or tor-browser-build
  • without any prior build started from this directory

comment:6 Changed 15 months ago by kfseaperson

The full logs of without any modification to rbm or tor-browser-build and without any prior build started from this directory are already present( as the zip file)
the log after the modification is not present here

The exact change is adding a hashtag at the beginning of line 1090 up and including 1095 on the file rmb/lib/rbm.pm

comment:7 Changed 15 months ago by boklm

So it seems there is an error somewhere in runc/remote_get. To get more details about where there is an error, you can try the following change:

diff --git a/rbm.conf b/rbm.conf
index 8cfa5e2..612b734 100644
--- a/rbm.conf
+++ b/rbm.conf
@@ -358,6 +358,7 @@ runc:
   remote_get: |
     #!/bin/sh
     set -e
+    set -x
     [%
       SET src = shell_quote(c('get_src', { error_if_undef => 1 }));
       SET dst = shell_quote(c('get_dst', { error_if_undef => 1 }));

comment:8 Changed 15 months ago by kfseaperson

Well if I run it now I got a new error
"Can't find container image in input files"

comment:9 Changed 15 months ago by kfseaperson

Maybe it is a good idea to add to the readme.builderrors (or to the rbm itself) instruction to change umask.
Since if rbm requires sudo (and creates files with root) with file permission without o+r (other may read) the "Can't find container image in input files" error is shown when a project is build by the end user account when requiring container image (or different input files).
allowing other to read all files is not in the philosophy of privacy (and so probably Tor Project one)
Users may have different umasks (the default permissions a file got when it is created) especially the more privacy caring ones(more strict than 022 (you can read write, other can read)), which shouldn't be rare with a product like Tor browser :)

comment:10 Changed 14 months ago by gk

Keywords: tbb-rbm added
Note: See TracTickets for help on using tickets.