Opened 2 years ago

Last modified 2 years ago

#26898 needs_information enhancement

add parameters for verified_host_names and unverified_host_names

Reported by: nusenu Owned by: metrics-team
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


the 'host_name' field is deprecated, lets add two search parameters
for the new fields recently added:

  • verified_host_names
  • unverified_host_names

and lets deprecate the host_name parameter in addition to the host_name field.

people can then use the verified_host_names parameter to search for all their relays in a way that is less vulnerable to attacks where a random operator injects himself into the result set.

The implementer decides whether these parameters accept single or multiple values.

Child Tickets

Change History (5)

comment:1 Changed 2 years ago by karsten

Hmm, I see the use case where somebody would only want to learn about verified host names. However, I'm not sure whether the suggested approach of splitting the host_name parameter into two parameters is the best way to do this.

An alternative would be to make it clearer in the documentation that results include relays with verified and unverified host names ending in the given search string. And whoever makes this query and cares about the verified/unverified bit would then have to filter the results locally.

Which option is less surprising? Seeing an interface with two very similar parameters, which by the way cannot be used together in a single query, plus the possible confusion when a request with one such *_host_name parameter will not return all relays with that host name? Or a situation in which a result contains both verified and unverified host names?

To be clear, the effort for adding two new parameters on existing data is relatively small. My main concerns are that we'd slowly clutter the interface and that this does not seem like a clear improvement over what's there.

Regarding your last suggestion of accepting multiple values, let's discuss that regardless of whether we're splitting the parameter or not. If it makes sense to search for (verified or unverified) host names ending in different strings, let's consider doing that.

comment:2 Changed 2 years ago by nusenu

Resolution: worksforme
Status: newclosed

neel decided to discontinue familygenerator so the motivation for this ticket is gone.

I've still a use-case for searching these fields but will open a separate ticket for that.

comment:3 Changed 2 years ago by karsten

Resolution: worksforme
Status: closedreopened

I noticed that you did not open that new ticket yet, unless I missed it. I'll reopen this one just to avoid that we're losing track of this feature request. We can still close this ticket if we're either working on this change as part of the other ticket, or deciding that we're not going to do it.

comment:4 Changed 2 years ago by karsten

Status: reopenedneeds_information

comment:5 Changed 2 years ago by nusenu

yes I didn't open the ticket yet since my use-case needs the data in the new fields and the new fields are not filled with much data yet (might be somewhat related to #26963 even though the ticket is specifically about the old host_name)

Note: See TracTickets for help on using tickets.