Changes between Initial Version and Version 1 of Ticket #26913, comment 2


Ignore:
Timestamp:
Aug 6, 2018, 2:08:35 AM (20 months ago)
Author:
teor
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #26913, comment 2

    initial v1  
    44It's https://github.com/torproject/tor/blob/3c490190163e227d37eb989b41df152e8500e059/src/app/config/config.c#L1557
    55
    6 It's tricky to suggest the right^TM fix. I think the easiest and foolproof fix is to change the default for CacheDirectory to be "DataDirectory"/cache (or even /var/cache/tor, if tor generally has permissions to create it in /var/cache on its own). Next option for a fix is to log a warning during configuration validity check if (DataDirectory == CacheDirectory  and DataDirectoryGroupReadable != CacheDirectoryGroupReadable), and maybe even fail hard rejecting the config as inconsistent.
     6It's tricky to suggest the right^TM^ fix. I think the easiest and foolproof fix is to change the default for CacheDirectory to be "DataDirectory"/cache (or even /var/cache/tor, if tor generally has permissions to create it in /var/cache on its own). Next option for a fix is to log a warning during configuration validity check if (DataDirectory == CacheDirectory  and DataDirectoryGroupReadable != CacheDirectoryGroupReadable), and maybe even fail hard rejecting the config as inconsistent.
    77
    88It regressed, because CacheDirectory stuff was added somewhat recently in #22703, so people with old configs without this var defined will all be affected.
    99
    1010PS. Two years after #19953: same bug (albeit for a different reason) and same fixer, lol.
     11
     12Edit: close superscript