#26925 closed defect (fixed)

Make link specifier handling in rend-spec-v3 more precise

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, doc, tor-relay, certs, handshake, ed25519, 035-roadmap-proposed, 035-must, fast-fix, 035-triaged-in-20180711
Cc: Actual Points:
Parent ID: #26627 Points:
Reviewer: asn Sponsor:

Description (last modified by teor)

Split off #26627.

We should specify that clients and services must not check untrusted link specifiers against the consensus:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705

Services should also copy unrecognized rend point link specifiers from the introduce cell to the rendezvous join cell.
We can copy the text from the service intro->rend spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1705
To the the client desc->intro spec:
https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n1338

Thanks to catalyst for picking up on these missing parts of the spec.

Edit: fix line numbers

Child Tickets

Change History (6)

comment:1 Changed 14 months ago by teor

Description: modified (diff)
Status: assignedneeds_review

See my branch bug26925 on https://github.com/teor2345/torspec.git

comment:2 Changed 14 months ago by teor

Description: modified (diff)

Now I have the right line numbers in the description.

comment:3 Changed 14 months ago by asn

Reviewer: asn

comment:4 Changed 14 months ago by asn

Status: needs_reviewmerge_ready

Spec changes LGTM. Are there any code changes that need to be done (i think not)?

comment:5 Changed 14 months ago by teor

Yes, we need to add IPv6 and unrecognized link specifiers to services in #24181, and unrecognised link specifiers to clients in #26971. (But they're not on our roadmap.)

Last edited 14 months ago by teor (previous) (diff)

comment:6 Changed 14 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged to master!

Note: See TracTickets for help on using tickets.