Opened 15 months ago

Closed 14 months ago

Last modified 6 months ago

#26937 closed enhancement (fixed)

sbws: Warn when there is not enough disk space

Reported by: juga Owned by: juga
Priority: Medium Milestone: sbws: 1.0.x-final
Component: Core Tor/sbws Version:
Severity: Normal Keywords:
Cc: pastly, juga@…, teor Actual Points:
Parent ID: #25925 Points:
Reviewer: Sponsor:

Child Tickets

Change History (8)

comment:1 Changed 15 months ago by juga

Description: modified (diff)

comment:2 Changed 14 months ago by juga

Status: assignedneeds_review

comment:3 Changed 14 months ago by pastly

Sorry. I haven't gotten to re-reviewing the PR because of I don't think that sbws even should have this code, thus I've never been motivated to look at it again.

I'll find time.

comment:4 Changed 14 months ago by teor

Some directory authority operators may deny access to disk space syscalls using a sandbox. Some sandboxes will terminate the process. Others will give bad results (like 0 or -1).

Directory authority operators have reported bugs in tor, because it made syscalls they weren't expecting.

Instead of checking for disk space, you could:

  • tell the operator how big the disk needs to be, and
  • ask them to install automatic disk space monitoring.

Documentation about disk space goes in the INSTALL file. You can put it with the other system requirements (like bandwidth and RAM).

Good documentation looks like this:

You will need X GB to install sbws and dependencies, and X GB to run sbws for a year on the public tor network.
We recommend that you set up automatic disk space monitoring on your data and log partitions.

Here are the details:

  • installing sbws uses X MB on top of the base system. The sbws tor client uses X MB.
  • sbws produces X MB of data files per day. Data files are cleaned up after X days. The remaining historical data is X MB per day.
  • sbws produces X MB of logs per day at notice level. (Does sbws work with logrotate? If not, how are logs rotated?)

comment:5 Changed 14 months ago by teor

Status: needs_reviewneeds_revision

We need the disk space documentation, even if we don't merge the code.

comment:6 Changed 14 months ago by juga

Status: needs_revisionneeds_review

I've implemented what you suggest in my branch ticket26937_02 (https://github.com/pastly/simple-bw-scanner/compare/master...juga0:ticket26937_02?expand=1).
I added at the end so that it won't have merge conflicts with #27341.

We can then close https://github.com/pastly/simple-bw-scanner/pull/241.

comment:7 Changed 14 months ago by pastly

Resolution: fixed
Status: needs_reviewclosed

Merged in PR 241 and 249.

comment:8 Changed 6 months ago by teor

Milestone: sbws: 1.0.x-final

Moving closed sbws tickets to sbws: 1.0.x-final.

Note: See TracTickets for help on using tickets.