Opened 12 months ago

Closed 10 months ago

Last modified 6 months ago

#26939 closed defect (fixed)

Privcount blinding and encryption: type fixes

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points: .2
Parent ID: #25669 Points:
Reviewer: teor Sponsor: SponsorV

Child Tickets

Change History (11)

comment:1 Changed 12 months ago by chelseakomlo

Just to further clarify from the comment on #25669- usize is Rust's equivalent of a size_t and therefore is used to pass around lengths or offsets of arrays or other collections. I wasn't sure about all of the uses of usize here, so taking another look might be useful. For example, https://github.com/nmathewson/privcount_shamir/blob/26812d1ab9912a8f36c0e1472b778d61e696c6e9/rust/tests/basic_integration.rs#L27 wasn't clear to me if this represents a length or offset, or the coordinates for Params https://github.com/nmathewson/privcount_shamir/blob/f679aa90ef3ce0d264c50f7e010b2b8022b96c7c/rust/src/shamir.rs#L15

Last edited 12 months ago by chelseakomlo (previous) (diff)

comment:2 Changed 11 months ago by teor

Owner: changed from teor to nickm

comment:3 Changed 11 months ago by nickm

Status: assignedneeds_review

I've done this as the first commit of my branch ticket26939_26943_26940; PR at https://github.com/nmathewson/privcount_shamir/pull/3 .

comment:4 Changed 11 months ago by asn

Reviewer: teor

comment:5 Changed 11 months ago by nickm

Sponsor: SponsorV

comment:6 Changed 10 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Deferring privcount tickets in 0.3.5 to 0.3.6

comment:7 Changed 10 months ago by teor

Status: needs_reviewmerge_ready

The first two commits in this branch look fine.

I opened a pull request to get CI:
https://github.com/teor2345/privcount_shamir/pull/5

Can you configure Travis CI on your privcount_shamir?

comment:8 Changed 10 months ago by nickm

Tried to do !

comment:9 Changed 10 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

(And merged the first two commits of that branch to kick it off.)

comment:10 Changed 8 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:11 Changed 6 months ago by nickm

Actual Points: .2
Note: See TracTickets for help on using tickets.