Opened 10 months ago

Closed 7 months ago

Last modified 4 months ago

#26940 closed defect (fixed)

Privcount blinding and encryption: doc fixes

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points: .1
Parent ID: #25669 Points:
Reviewer: teor Sponsor: SponsorV

Child Tickets

Change History (10)

comment:1 Changed 10 months ago by teor

I also need to fix the format of the doc comments, see:
https://trac.torproject.org/projects/tor/ticket/26942?replyto=4#comment:4

comment:2 Changed 9 months ago by teor

Owner: changed from teor to nickm

comment:3 Changed 9 months ago by nickm

Status: assignedneeds_review

I've done this as the final part of my branch ticket26939_26943_26940; PR at https://github.com/nmathewson/privcount_shamir/pull/3 .

While doing this I fixed a couple of extra bugs, one big, one small.

  • big: it was possible to create a TR whose public key would give it an X coordinate of zero. If you did that, then the TR's "share" would actually be the un-split secret data. Good thing we caught this before production!
  • small: the Rand implementation for FE didn't use the from_u64_unbiased method.

If you'd like even more doctests, I'd like to do that after merging this branch, since it's already grown pretty large.

comment:4 Changed 9 months ago by asn

Reviewer: teor

comment:5 Changed 9 months ago by nickm

Sponsor: SponsorV

comment:6 Changed 8 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Deferring privcount tickets in 0.3.5 to 0.3.6

comment:7 Changed 8 months ago by teor

Status: needs_reviewneeds_revision

Looks good to me. The new documentation is helpful for understanding the code.

See my comments on the pull request, I found a few typos.

After they're fixed, let's merge,

comment:8 Changed 7 months ago by nickm

Resolution: fixed
Status: needs_revisionclosed

Merged, with typos fixed!

comment:9 Changed 6 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:10 Changed 4 months ago by nickm

Actual Points: .1
Note: See TracTickets for help on using tickets.