Opened 5 months ago

Last modified 5 weeks ago

#26941 assigned defect

Privcount blinding and encryption: review dependencies

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points:
Parent ID: #25669 Points:
Reviewer: Sponsor: SponsorV

Description

Child Tickets

Change History (5)

comment:1 Changed 4 months ago by teor

Owner: changed from teor to nickm

comment:2 Changed 4 months ago by nickm

Sponsor: SponsorV

comment:3 Changed 3 months ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

These are not on track for 0.3.5, given the amount of time remaining before freeze.

comment:4 Changed 8 weeks ago by teor

Komlo said:
I see that this crate depends on several external crates. rust-crypto states that it doesn't have strong security guarantees- is there something else that we should be using? ​https://crates.io/crates/rust-crypto.
Should we have an auditing process for when we choose to import/use new external crates?

nickm says:
hm. I don't think we have something else we should necessarily use yet, though probably we should make the code so it's parameterized on the crypto traits we need eventually
I think it's something we can clean up later.
I think what we want is a pattern where we have some traits, maybe copied from rust-crypto, or maybe theirs, for crypto, and we instantiate them either with a rust implementation or the Tor c implementation
looks like for this we need sha3/shake, aes, curve25519, and a time-invariant comparison

comment:5 Changed 5 weeks ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

Note: See TracTickets for help on using tickets.