Opened 3 months ago

Closed 6 days ago

#26943 closed defect (fixed)

Privcount blinding and encryption: Safety fixes

Reported by: teor Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.6.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points:
Parent ID: #25669 Points:
Reviewer: teor Sponsor: SponsorV

Child Tickets

Change History (7)

comment:1 Changed 2 months ago by teor

Owner: changed from teor to nickm

comment:2 Changed 2 months ago by nickm

Status: assignedneeds_review

I've done this as the middle part of my branch ticket26939_26943_26940; PR at https://github.com/nmathewson/privcount_shamir/pull/3 . All of the unwrap() and assert! calls are now confined to the tests.

This makes a lot more things return a Result than did before, but thanks to the ? operator, the code is fairly clean.

Also, it is really cool that Result<Vec<X>,Y> implements FromIterator<Result<X,Y>>.

comment:3 Changed 2 months ago by asn

Reviewer: teor

comment:4 Changed 2 months ago by nickm

Sponsor: SponsorV

comment:5 Changed 5 weeks ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Deferring privcount tickets in 0.3.5 to 0.3.6

comment:6 Changed 5 weeks ago by teor

Status: needs_reviewmerge_ready

Commits 3-5 look good.

The CI is here:
https://github.com/teor2345/privcount_shamir/pull/5

comment:7 Changed 6 days ago by nickm

Resolution: fixed
Status: merge_readyclosed

Merged the branch !

Note: See TracTickets for help on using tickets.