tor_run_main crashes when called a second time with --version

I wrote a testing harness that uses python and cffi, to implement some basic smoke tests for libtor. This can be found here: ​https://gist.github.com/hellais/b56043d57eb5be885958e80b3665bfe2 (to run it do pip install cffi and change the LIB_PATH to the correct path).

In particular by adding the command line flag --version and starting tor, I am unable to re-start it due to the exception listed in the above gist.

changed milestone to %Tor: 0.3.5.x-final

added 033-backport 034-backport component::core tor/tor fast-fix milestone::Tor: 0.3.5.x-final owner::nickm parent::25510 priority::medium resolution::fixed reviewer::ahf severity::normal status::closed type::defect labels

Trac:
Milestone: N/A to Tor: 0.3.5.x-final
Keywords: N/A deleted, 034-backport fast-fix added

Trac:
Owner: N/A to nickm
Status: new to accepted

Okay; the problem here was that some variables weren't getting cleared in the case that we left tor_run_main() early. Bugfix in branch bug26948_033; PR at https://github.com/torproject/tor/pull/255 .

Trac:
Status: accepted to needs_review
Keywords: 034-backport fast-fix deleted, 034-backport fast-fix 033-backport added

I have testing the branch at tip a67d153cc with the above mentioned script and it works for me:

- running test_get_tor_version()
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
- running test_get_tor_version_many()
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).
Tor version 0.3.3.8-dev (git-a67d153cc7493f91).

Thanks for fixing this.

Trac:
Reviewer: N/A to ahf

Neat. LGTM.

Trac:
Status: needs_review to merge_ready

merged, I believe!

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

moved to tpo/core/tor#26948 (closed)