#26953 closed defect (fixed)

Privcount blinding and encryption: add travis CI

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points:
Parent ID: #25669 Points:
Reviewer: Sponsor:

Description

Because I don't want to spend all my time running multiple builds.

Child Tickets

Change History (5)

comment:1 Changed 15 months ago by teor

Status: assignedneeds_review

Please see my branch ci-osx on https://github.com/teor2345/privcount_shamir.git

I'm going to merge it to my master once CI passes, so I can use it as the base for my other branches. (Otherwise, they won't have any CI.)

comment:3 Changed 15 months ago by chelseakomlo

This looks good to me, but someone else who has worked with Travis more should also take a look.

Is the idea that this project will remain external to core tor, or will this one day be merged into the core codebase? Definitely having CI in the short term seems wise either way.

comment:4 in reply to:  3 Changed 15 months ago by teor

Replying to chelseakomlo:

This looks good to me, but someone else who has worked with Travis more should also take a look.

I expect someone will be assigned to review this ticket today.

I'll answer your other question in #26970.

comment:5 Changed 15 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

this looks fine to me, and it can't break anything anybody is depending on. Merged!

Note: See TracTickets for help on using tickets.