#26955 closed defect (implemented)

Privcount blinding and encryption: rustfmt

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points:
Parent ID: #25669 Points:
Reviewer: Sponsor:

Description

I'm going to rustfmt the entire codebase, so I don't have spurious changes when I edit particular files.

Child Tickets

Change History (6)

comment:1 Changed 12 months ago by teor

Status: assignedneeds_review

Please see my branch rustfmt on ​https://github.com/teor2345/privcount_shamir.git

I'm going to merge it to my master once CI passes, so I can use it as the base for my other branches. (Otherwise, I'll end up with spurious whitespace changes in my other branches.)

comment:3 Changed 12 months ago by chelseakomlo

There are a lot of changes in this PR so I didn't look at each one closely, but (from what I saw) if these changes are all automatic changes from running rustfmt on each file, then this looks good to merge to me.

Btw, I set up my .vimrc to run rustfmt each time I save on the file that I'm working on, it might be helpful to do this for future work. This is what I used but I'm sure there are other options https://github.com/rust-lang/rust.vim#formatting-with-rustfmt

As a note to the future, we should probably set up a CI task for core tor to check if Rust files haven't been formatted with rustfmt (I don't think we do this currently after looking at the build). I can open a ticket to track this.

comment:4 in reply to:  3 ; Changed 12 months ago by teor

Status: needs_reviewmerge_ready

Replying to chelseakomlo:

There are a lot of changes in this PR so I didn't look at each one closely, but (from what I saw) if these changes are all automatic changes from running rustfmt on each file, then this looks good to merge to me.

Thanks!

Btw, I set up my .vimrc to run rustfmt each time I save on the file that I'm working on, it might be helpful to do this for future work. This is what I used but I'm sure there are other options https://github.com/rust-lang/rust.vim#formatting-with-rustfmt

I have done the same with emacs:
https://github.com/rust-lang/rust-mode

As a note to the future, we should probably set up a CI task for core tor to check if Rust files haven't been formatted with rustfmt (I don't think we do this currently after looking at the build). I can open a ticket to track this.

Thanks! Please post the ticket number here.

I opened #26973 for the same change to the privcount_shamir CI.

comment:5 in reply to:  4 Changed 12 months ago by teor

Replying to teor:

Replying to chelseakomlo:

As a note to the future, we should probably set up a CI task for core tor to check if Rust files haven't been formatted with rustfmt (I don't think we do this currently after looking at the build). I can open a ticket to track this.

Thanks! Please post the ticket number here.

I opened #26973 for the same change to the privcount_shamir CI.

Oh, I see, it's #26972 for core tor rustfmt.

comment:6 Changed 12 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Merged!

Note: See TracTickets for help on using tickets.