Opened 3 months ago

Last modified 5 weeks ago

#26958 needs_revision defect

Privcount blinding and encryption: run clippy on travis rust nightly

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.6.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: privcount, 035-roadmap-master, 035-triaged-in-20180711, rust
Cc: teor, nickm, chelseakomlo Actual Points:
Parent ID: #25669 Points:
Reviewer: Sponsor: SponsorV

Description

We'll need to fix or disable a lot of warnings for clippy.

Child Tickets

Change History (5)

comment:1 Changed 3 months ago by teor

Status: assignedneeds_revision

I have an incomplete branch that runs clippy, and fails due to lots of clippy warnings in bug26958.

I don't know if we should fix the code causing these warnings, or allow the warnings.

For a list of the warnings, see the nightly builds in:
https://travis-ci.org/teor2345/privcount_shamir/builds/408862027

Edit: use the build without stable errors

Last edited 3 months ago by teor (previous) (diff)

comment:2 Changed 3 months ago by teor

In #22156, we made clippy an optional makefile target in tor, for these reasons:
https://trac.torproject.org/projects/tor/ticket/22156#comment:1

comment:3 Changed 3 months ago by chelseakomlo

Hey! Yes I don't think passing all clippy warnings should be mandatory. It is useful to run clippy locally, and overall we should in the future come up with a set of clippy warnings that we want to pass by default, but for the short term it probably? shouldn't be part of the CI build. See https://trac.torproject.org/projects/tor/ticket/22156 for more context.

With that said, looking over these warnings locally and fixing up those which could result in actual bugs seems like a good idea.

comment:4 Changed 8 weeks ago by nickm

Sponsor: SponsorV

comment:5 Changed 5 weeks ago by nickm

Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final

Deferring privcount tickets in 0.3.5 to 0.3.6

Note: See TracTickets for help on using tickets.