Opened 17 months ago
Last modified 9 months ago
#26958 needs_revision defect
Privcount blinding and encryption: run clippy on travis rust nightly
| Reported by: | teor | Owned by: | |
|---|---|---|---|
| Priority: | Medium | Milestone: | Tor: unspecified |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Normal | Keywords: | privcount, 035-roadmap-master, 035-triaged-in-20180711, rust, 040-unreached-20190109, teor-unreached-2019-03-08 |
| Cc: | teor, nickm, chelseakomlo | Actual Points: | |
| Parent ID: | #25669 | Points: | |
| Reviewer: | Sponsor: | SponsorV-can |
Description
We'll need to fix or disable a lot of warnings for clippy.
Child Tickets
Change History (9)
comment:1 Changed 17 months ago by
| Status: | assigned → needs_revision |
|---|
comment:2 Changed 17 months ago by
In #22156, we made clippy an optional makefile target in tor, for these reasons:
https://trac.torproject.org/projects/tor/ticket/22156#comment:1
comment:3 Changed 17 months ago by
Hey! Yes I don't think passing all clippy warnings should be mandatory. It is useful to run clippy locally, and overall we should in the future come up with a set of clippy warnings that we want to pass by default, but for the short term it probably? shouldn't be part of the CI build. See https://trac.torproject.org/projects/tor/ticket/22156 for more context.
With that said, looking over these warnings locally and fixing up those which could result in actual bugs seems like a good idea.
comment:4 Changed 16 months ago by
| Sponsor: | → SponsorV |
|---|
comment:5 Changed 15 months ago by
| Milestone: | Tor: 0.3.5.x-final → Tor: 0.3.6.x-final |
|---|
Deferring privcount tickets in 0.3.5 to 0.3.6
comment:6 Changed 13 months ago by
| Milestone: | Tor: 0.3.6.x-final → Tor: 0.4.0.x-final |
|---|
Tor 0.3.6.x has been renamed to 0.4.0.x.
comment:7 Changed 11 months ago by
| Keywords: | 040-unreached-20190109 added |
|---|---|
| Milestone: | Tor: 0.4.0.x-final → Tor: unspecified |
These tasks aren't essential for a PrivCount proof of concept: moving them to Tor: unspecified.
comment:8 Changed 9 months ago by
| Keywords: | teor-unreached-2019-03-08 added |
|---|---|
| Owner: | teor deleted |
| Sponsor: | SponsorV → SponsorV-can |
| Status: | needs_revision → assigned |
comment:9 Changed 9 months ago by
| Status: | assigned → needs_revision |
|---|
I have an incomplete branch that runs clippy, and fails due to lots of clippy warnings in bug26958.
I don't know if we should fix the code causing these warnings, or allow the warnings.
For a list of the warnings, see the nightly builds in:
https://travis-ci.org/teor2345/privcount_shamir/builds/408860393