Opened 8 weeks ago

Closed 5 weeks ago

#26960 closed defect (fixed)

implement new about:tor start page

Reported by: mcs Owned by: mcs
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201808R
Cc: tbb-team, ux-team Actual Points:
Parent ID: #25695 Points:
Reviewer: Sponsor:

Description (last modified by mcs)

This ticket is to track implementation of the start page portion of #25695.

Child Tickets

Change History (7)

comment:1 Changed 8 weeks ago by mcs

Description: modified (diff)

comment:2 Changed 8 weeks ago by mcs

Keywords: TorBrowserTeam201807R added; TorBrowserTeam201807 removed
Status: assignedneeds_review

This is ready for review:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug26960-01

For now, we preserved the "Tor is not working in this browser" mode: when the Tor check fails, the about:tor page displays the following text on a red background (#A4000F) :

Something Went Wrong!
Tor is not working in this browser.

We used the CSS and HTML method to render the onion pattern that is included at the bottom of the page. We included 14 onions across in each row, which means if someone has a really wide display the shapes will not fill the entire width of their window. I think this is OK.

We cannot use the @2x and @3x images because the display density is spoofed and always appears to the CSS rules as 1.0 when privacy.resistFingerprinting is true. We will need to think about how to fix that problem.

One comment on the design: we should consider reducing the empty vertical space above and below the search box. As it is, on many laptop displays the onion design is mostly off the bottom of the page, and on smaller displays (e.g., a 14" Win10 laptop) the link to the manual and the Tor mission text is not visible without scrolling.

comment:3 Changed 7 weeks ago by gk

Looks good! One additional thing I am wondering is whether we should make our "Questions? Check our Tor Browser Manual »" part larger/show it more prominently. After all, it provides useful information to actually stay secure with Tor Browser and is not just about questions that are showing up during usage.

comment:4 Changed 7 weeks ago by gk

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201807R removed

comment:5 Changed 7 weeks ago by gk

Priority: MediumVery High

Bumping prio.

comment:6 in reply to:  3 Changed 6 weeks ago by mcs

Replying to gk:

Looks good! One additional thing I am wondering is whether we should make our "Questions? Check our Tor Browser Manual »" part larger/show it more prominently.

Here is a revised patch that adds some vertical space below the manual link, increases the font size used for it, and reduces slightly the empty vertical space above and below the middle portion of the page:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug26960-02&id=1e191fed00de1bbb8c89b819992d69a69b7e3026

comment:7 Changed 5 weeks ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks, great work! I cherry-picked it to master (commit 985bcbf8323c159b18345fbfc010a7277d54559f).

Note: See TracTickets for help on using tickets.