Privcount blinding and encryption: add rustfmt CI check

We should check that rustfmt has been run on the privcount_shamir code in our CI. See: https://trac.torproject.org/projects/tor/ticket/26955?replyto=3#comment:3

changed milestone to %Tor: 0.4.0.x-final

added 035-roadmap-master 035-triaged-in-20180711 actualpoints::0.5 component::core tor/tor milestone::Tor: 0.4.0.x-final owner::teor parent::25669 priority::medium privcount resolution::implemented reviewer::nickm rust severity::normal sponsor::V status::closed type::defect labels

We can copy the code and configs from #26972 (moved), which does rustfmt checks for tor.

Please see my branch ticket26973 in https://github.com/teor2345/privcount_shamir.git

I disabled the rustfmt check because rust stable and beta disagree about some formatting. For example, see: https://travis-ci.org/teor2345/privcount_shamir/jobs/414426254#L1612

The passing build is: https://travis-ci.org/teor2345/privcount_shamir/builds/414430540

I still think we should merge this patch, because the current code passes the rustfmt check with rustfmt 0.99.1.

Then we should defer the remaining tasks until Tor 0.3.6:

• wait until rustfmt 0.99.1 hits stable
• do a final format with rustfmt
• activate the travis rustfmt check

Assigning to nickm, because he probably wants to merge the rustfmt changes before starting other rust tickets.

Trac:
Reviewer: N/A to nickm
Status: assigned to needs_review

This looks okay, except for the fact that the rustfmt commit itself will have conflicts with my patch series currently under review.

So my current plan here is that, once that other patch series is merged, we should cherry-pick everything from this branch except for the rustfmt commit (bdc2db60153ef9c3044b72309cc1b35f45f85618), and then re-run rustfmt separately.

Trac:
Status: needs_review to merge_ready

Sounds good.

We should re-run nightly rustfmt, because nightly and stable format the files differently.

Trac:
Sponsor: N/A to SponsorV

Deferring privcount tickets in 0.3.5 to 0.3.6

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.3.6.x-final

Teor -- I'll do this once you say the time is ripe, or you can do it. I'm not hacking on this repo for the next few days at least.

Hi nickm, now would be a good time to re-run rustfmt, and merge this ticket.

No-one is working on PrivCount right now.

Okay -- merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

Tor 0.3.6.x has been renamed to 0.4.0.x.

Trac:
Milestone: Tor: 0.3.6.x-final to Tor: 0.4.0.x-final

Trac:
Actualpoints: N/A to 0.5

closed

added 4h of time spent

moved to tpo/core/tor#26973 (closed)