#26979 closed defect (fixed)

Appveyor CI IRC shows the wrong branch for pull requests

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.4.x-final
Component: Core Tor/Tor Version: Tor:
Severity: Normal Keywords: tor-ci, appveyor, windows, fast-fix, 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


For example, the branch that Neel opened a pull request for is b23588, based on master:

11:49 appveyor-ci: torproject/tor master 1752b17 - Neel Chauhan: Add changes file for Bug #23588
11:49 appveyor-ci: Build #1.0.450 failed. Details: https://ci.appveyor.com/project/torproject/tor/build/1.0.450

If I can't fix this in a few minutes tomorrow, I'll leave it for later.

Child Tickets

Change History (6)

comment:1 Changed 22 months ago by teor

Milestone: Tor: unspecifiedTor: 0.3.5.x-final
Status: assignedneeds_review

Please see my branch bug26979 on https://github.com/teor2345/tor.git

It produces the following output on pull requests:

torproject/tor master pull teor2345/tor bug26979 c3fca338a2 - teor: Appveyor CI: always use HEAD for the short commit
Build #1.0.470 failed. Details: https://ci.appveyor.com/project/torproject/tor/build/1.0.470
Commit: https://github.com/teor2345/tor/commit/c3fca338a2c63241497b64a9f997c28f17ef1b6a
Pull: https://github.com/torproject/tor/pull/253

And the following output on tags:

teor2345/tor bug26979-appveyor-tag-test 3d3e62d147 - teor: Appveyor CI: Switch to one URL per line
Build #1.0.30 failed. Details: https://ci.appveyor.com/project/teor2345/tor/build/1.0.30
Commit: https://github.com/teor2345/tor/commit/3d3e62d1474a386f6a46fe6a8c5d6c7c5bed4f85

The builds fail due to #26986.

comment:2 Changed 22 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

looks okay to me -- merged to master

comment:3 Changed 22 months ago by teor

Milestone: Tor: 0.3.5.x-finalTor: 0.3.4.x-final
Resolution: fixed
Status: closedreopened
Version: Tor: unspecifiedTor:

.appveyor.yml was introduced in 0.3.4, so we should also backport this fix, otherwise 0.3.4 branches will be confusingly different from 0.3.5 branches.

See my branch bug26979-034

comment:4 Changed 22 months ago by teor

Keywords: 034-backport added
Status: reopenedmerge_ready

comment:6 Changed 22 months ago by nickm

Resolution: fixed
Status: merge_readyclosed

Good by me. Merged to 0.3.4 and forward.

Note: See TracTickets for help on using tickets.