Opened 2 years ago

Closed 2 years ago

#26985 closed defect (fixed)

help button icons missing

Reported by: mcs Owned by: mcs
Priority: Very High Milestone:
Component: Applications/Tor Launcher Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201807R
Cc: tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When Tor Launcher is running inside an ESR60-based Tor Browser, the bridge and proxy help button icons are missing. This is because we reused an image that was part of Firefox, and Mozilla removed the image sometime between ESR52 and ESR60.

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by mcs

The image from ESR52 is chrome://browser/skin/menuPanel-help.png (in the source tree, the path is browser/themes/linux/menuPanel-help.png on Linux and similar images exist for Windows and macOS). The image contains multiple renderings to cover "on click" and "on hover" states which we use in Tor Launcher.

The replacement image that is in ESR60 is chrome://global/skin/icons/help.svg (in the source tree there is just one image at toolkit/themes/shared/icons/help.svg). Since this image does not have "on click" and "on hover" renderings, we will need to decide what we want to do in those cases. In the hamburger menu where Firefox uses this new image, the background color of the entire menu row is changed upon hover but that is not appropriate in Tor Launcher since we use the help icons for standalone buttons.

comment:2 Changed 2 years ago by mcs

Keywords: TorBrowserTeam201807R added; TorBrowserTeam201807 removed
Status: assignedneeds_review

comment:3 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Cherry-picked to master (commit 2a2a1ac8da14983ff682c46e0d8426cb2590ec41).

Note: See TracTickets for help on using tickets.