help button icons missing

When Tor Launcher is running inside an ESR60-based Tor Browser, the bridge and proxy help button icons are missing. This is because we reused an image that was part of Firefox, and Mozilla removed the image sometime between ESR52 and ESR60.

added TorBrowserTeam201807R component::applications/tor launcher ff60-esr owner::mcs priority::very high resolution::fixed severity::normal status::closed type::defect labels

The image from ESR52 is chrome://browser/skin/menuPanel-help.png (in the source tree, the path is browser/themes/linux/menuPanel-help.png on Linux and similar images exist for Windows and macOS). The image contains multiple renderings to cover "on click" and "on hover" states which we use in Tor Launcher.

The replacement image that is in ESR60 is chrome://global/skin/icons/help.svg (in the source tree there is just one image at toolkit/themes/shared/icons/help.svg). Since this image does not have "on click" and "on hover" renderings, we will need to decide what we want to do in those cases. In the hamburger menu where Firefox uses this new image, the background color of the entire menu row is changed upon hover but that is not appropriate in Tor Launcher since we use the help icons for standalone buttons.

Here is a fix: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug26985-01&id=bfb93a4325709c5d0d0498fc9d7eb80019cbabd8

Trac:
Keywords: TorBrowserTeam201807 deleted, TorBrowserTeam201807R added
Status: assigned to needs_review

Looks good. Cherry-picked to master (commit 2a2a1ac8da14983ff682c46e0d8426cb2590ec41).

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-launcher#26985 (closed)