Opened 3 weeks ago

Closed 2 weeks ago

#26994 closed defect (implemented)

Solaris 10: test_bwmgt.c compile error with tor-0.3.4.5-rc

Reported by: Knut Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.5-rc
Severity: Normal Keywords: tor-test, solaris, regression, 035-must 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by teor)

I'm running in the same compile error on all tor-0.3.4.* versions
when trying to build tor on Solaris 10
tor-0.3.3.9 builds and works without any issue.

The error looks like:

In file included from /usr/include/sys/select.h:23:0,
                 from /usr/include/sys/types.h:616,
                 from /usr/include/unistd.h:20,
                 from ./src/or/or.h:18,
                 from src/test/test_bwmgt.c:11:
src/test/test_bwmgt.c: In function ‘test_bwmgt_token_buf_refill’:
src/test/test_bwmgt.c:127:18: error: expected identifier or ‘(’ before numeric constant
   const uint32_t SEC =
                  ^
gmake[1]: *** [src/test/src_test_test-test_bwmgt.o] Error 1
gmake[1]: Leaving directory `/usr/local/lib/tor-0.3.4.5-rc'
gmake: *** [all] Error 2

Any help is appreciated.

Thanks.

Knut

Child Tickets

Attachments (1)

tor_make.log (35.0 KB) - added by Knut 3 weeks ago.
output from make

Download all attachments as: .zip

Change History (6)

Changed 3 weeks ago by Knut

Attachment: tor_make.log added

output from make

comment:1 Changed 3 weeks ago by teor

Component: Core TorCore Tor/Tor
Description: modified (diff)
Keywords: tor-test solaris regression 035-must added; test_bwmgt.c removed
Milestone: Tor: 0.3.5.x-final
Status: newneeds_information

Hi, thanks for this bug report.

Do any standard Solaris headers define a macro "SEC"?

What happens if you search and replace "SEC" with "BW_SEC" in test_bwmgt.c?

comment:2 Changed 3 weeks ago by nickm

Summary: test_bwmgt.c compile error with tor-0.3.4.5-rcSolaris 10: test_bwmgt.c compile error with tor-0.3.4.5-rc

comment:3 Changed 3 weeks ago by Knut

Hi teor,

search and replace "SEC" with "BW_SEC" in test_bwmgt.c worked.

Thanks a lot.

knut

comment:4 Changed 2 weeks ago by nickm

Keywords: 034-backport added
Owner: set to nickm
Status: needs_informationaccepted

comment:5 Changed 2 weeks ago by nickm

Resolution: implemented
Status: acceptedclosed

I've merged the fix that Teor describes (rename SEC to BW_SEC in test_bwmgt.c) as a54e94878a438a269659387b9e6eea84f7e12771. It should appear in 0.3.4.6-rc.

Note: See TracTickets for help on using tickets.