Opened 8 months ago

Closed 7 months ago

#26998 closed enhancement (implemented)

Make suggested changes to per-graph CSV files and deploy them after August 15

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Website Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

On July 31 we deployed an updated stats.html with a bunch of suggestions to per-graph CSV files. We said we'd make those changes after August 15. Let's prepare one or more patches, get them reviewed, and deploy them on or shortly after August 15.

I'll leave this ticket assigned to metrics-team for now, just in case somebody else wants to give this a try. But if it's not taken by next week, I'll grab it.

This is still part of #25383.

Child Tickets

Change History (5)

comment:1 Changed 8 months ago by karsten

Owner: changed from metrics-team to karsten
Status: assignedaccepted

Grabbing.

comment:2 Changed 8 months ago by karsten

Status: acceptedneeds_review

comment:3 Changed 7 months ago by irl

Status: needs_reviewmerge_ready

This looks good to me. I did not try running the R code but the changes do look to match up with the text.

comment:4 Changed 7 months ago by karsten

Okay, great! I'm merging this now.

Here's one smaller change that I'm also making, which is based on a bug report in an unrelated ticket:

diff --git a/src/main/R/rserver/graphs.R b/src/main/R/rserver/graphs.R
index 2502c0e9..66a1414e 100644
--- a/src/main/R/rserver/graphs.R
+++ b/src/main/R/rserver/graphs.R
@@ -895,7 +895,8 @@ plot_userstats <- function(start_p, end_p, node_p, variable_p, value_p,
     events_p, path_p) {
   load(paste(rdata_dir, "clients-", node_p, ".RData", sep = ""))
   c <- data
-  u <- c[c$date >= start_p & c$date <= end_p, ]
+  u <- c[c$date >= start_p & c$date <= end_p, c("date", "country", "transport",
+      "version", "lower", "upper", "clients")]
   u <- rbind(u, data.frame(date = start_p,
       country = ifelse(variable_p == "country" & value_p != "all", value_p, ""),
       transport = ifelse(variable_p == "transport", value_p, ""),

I'm going to squash that change into 895a111 when rebasing to master.

comment:5 Changed 7 months ago by karsten

Resolution: implemented
Status: merge_readyclosed

Merged and deployed. Closing. Thanks!

Note: See TracTickets for help on using tickets.