Opened 4 months ago

Closed 4 months ago

#27020 closed defect (fixed)

RBM build fails with runc version 1.01

Reported by: pospeselr Owned by: pospeselr
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201808R
Cc: boklm, tbb-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

RBM build fails with latest runc version (1.0.1)

Child Tickets

Change History (8)

comment:1 Changed 4 months ago by sukhbir

I think the latest version is not supported because of the differences in the spec. What's the exact error?

EDIT: Specifically, I *think* we will need to update projects/common/runc-config.json to match https://github.com/opencontainers/runtime-spec/blob/master/config.md.

Last edited 4 months ago by sukhbir (previous) (diff)

comment:2 Changed 4 months ago by pospeselr

Cc: boklm added
Status: assignedneeds_review

comment:3 in reply to:  2 Changed 4 months ago by boklm

Status: needs_reviewneeds_revision

Replying to pospeselr:

Patch with the newest runc version string:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Some comments about the patch:

  • there is a typo in the commit message: currenetly
  • we should add \ before the dots in 1.0.1
  • maybe we should match 1\.0\.\d so that we don't need to update it when there is a version 1.0.2.
  • we should also update the comment that currently says runc_spec100 is true if runc spec is exactly 1.0.0

comment:4 Changed 4 months ago by boklm

Component: Applications/rbmApplications/Tor Browser
Keywords: tbb-rbm TorBrowserTeam201808 added

comment:5 Changed 4 months ago by boklm

Cc: tbb-team added

comment:6 Changed 4 months ago by pospeselr

Status: needs_revisionneeds_review

Updated patch to set the flag for versions greater than 1.0.0:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

comment:7 Changed 4 months ago by boklm

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed

comment:8 in reply to:  6 Changed 4 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to pospeselr:

Updated patch to set the flag for versions greater than 1.0.0:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Thanks. I squashed the two commits and pushed that to master as commit 3960ad5d91701ef9b22e57eef8532e7a2e19b9db.

Note: See TracTickets for help on using tickets.