RBM build fails with runc version 1.01

RBM build fails with latest runc version (1.0.1)

added TorBrowserTeam201808R component::applications/tor browser owner::pospeselr priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

I think the latest version is not supported because of the differences in the spec. What's the exact error?

EDIT: Specifically, I think we will need to update projects/common/runc-config.json to match https://github.com/opencontainers/runtime-spec/blob/master/config.md.

Patch with the newest runc version string:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Trac:
Status: assigned to needs_review
Cc: N/A to boklm

Replying to pospeselr:

Patch with the newest runc version string:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Some comments about the patch:

• there is a typo in the commit message: currenetly
• we should add \ before the dots in 1.0.1
• maybe we should match 1\.0\.\d so that we don't need to update it when there is a version 1.0.2.
• we should also update the comment that currently says runc_spec100 is true if runc spec is exactly 1.0.0

Trac:
Status: needs_review to needs_revision

Trac:
Keywords: N/A deleted, TorBrowserTeam201808, tbb-rbm added
Component: Applications/rbm to Applications/Tor Browser

Trac:
Cc: boklm to boklm, tbb-team

Updated patch to set the flag for versions greater than 1.0.0:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Trac:
Status: needs_revision to needs_review

Trac:
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201808R added

Replying to pospeselr:

Updated patch to set the flag for versions greater than 1.0.0:

https://gitweb.torproject.org/user/richard/tor-browser-build.git/commit/?h=bug_27020

Thanks. I squashed the two commits and pushed that to master as commit 3960ad5d91701ef9b22e57eef8532e7a2e19b9db.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-browser#27020 (closed)