#27060 closed enhancement (implemented)

Improve coverage in a few high-coverage modules

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-test
Cc: Actual Points:
Parent ID: Points:
Reviewer: dgoulet Sponsor:

Description

I wrote some tests last night while I was burned out on other things.

Child Tickets

Change History (9)

comment:1 Changed 18 months ago by nickm

Status: assignedneeds_review

See branch "coverage_6aug"; PR at https://github.com/torproject/tor/pull/264

comment:2 Changed 18 months ago by nickm

Milestone: Tor: 0.3.5.x-final

comment:3 Changed 18 months ago by nickm

Status: needs_reviewneeds_revision

CI says it has memory leaks; will revise.

comment:4 Changed 18 months ago by nickm

Status: needs_revisionneeds_review

Should be better now.

comment:5 Changed 18 months ago by teor

Summary: Improve coverag in a few high-coverage modulesImprove coverage in a few high-coverage modules

Fix typo

comment:6 Changed 17 months ago by asn

Reviewer: dgoulet

comment:7 Changed 17 months ago by dgoulet

Keywords: tor-test added
Status: needs_reviewneeds_revision

Travis clang build is unhappy. Seems a memory leak:

https://travis-ci.org/torproject/tor/jobs/413090101#L3206

Apart from that, lgtm;

comment:8 Changed 17 months ago by dgoulet

Status: needs_revisionmerge_ready

ACK.

comment:9 Changed 17 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

merged!

Note: See TracTickets for help on using tickets.