Opened 7 months ago
Closed 6 months ago
#27061 closed task (fixed)
Enable verification of langpacks checksums
Reported by: | boklm | Owned by: | tbb-team |
---|---|---|---|
Priority: | Medium | Milestone: | |
Component: | Applications/Tor Browser | Version: | |
Severity: | Normal | Keywords: | tbb-rbm, TorBrowserTeam201808R |
Cc: | Actual Points: | ||
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
When switching to esr60 we temporarily disabled the checking of langpacks checksums in projects/firefox-langpacks/build
because they were missing in the SHA512SUMS files.
It looks like the bug causing this issue will be fixed soon:
https://bugzilla.mozilla.org/show_bug.cgi?id=1463749
We should enable this check again in the next release where this bug has been fixed.
Child Tickets
Change History (5)
comment:1 Changed 6 months ago by
comment:2 follow-up: 4 Changed 6 months ago by
Status: | new → needs_review |
---|
Review:
https://github.com/azadi/tor-browser-build-1/tree/bug-27061
Note: this modifies only firefox-langpacks
and does not set the firefox_platform_version
. Let me know if it should do that as well. (Also this assumes 60.2 for tor-browser since that has the relevant patches but then again, that's not covered in this patch.)
comment:3 Changed 6 months ago by
Keywords: | TorBrowserTeam201808R added; TorBrowserTeam201808 removed |
---|
comment:4 follow-up: 5 Changed 6 months ago by
Replying to sukhbir:
Review:
https://github.com/azadi/tor-browser-build-1/tree/bug-27061
Note: this modifies only
firefox-langpacks
and does not set thefirefox_platform_version
. Let me know if it should do that as well. (Also this assumes 60.2 for tor-browser since that has the relevant patches but then again, that's not covered in this patch.)
No, that's fine. This looks good to me. I'll apply this while we are switching to 60.2.0esr, thanks.
comment:5 Changed 6 months ago by
Resolution: | → fixed |
---|---|
Status: | needs_review → closed |
Replying to gk:
Replying to sukhbir:
Review:
https://github.com/azadi/tor-browser-build-1/tree/bug-27061
Note: this modifies only
firefox-langpacks
and does not set thefirefox_platform_version
. Let me know if it should do that as well. (Also this assumes 60.2 for tor-browser since that has the relevant patches but then again, that's not covered in this patch.)
No, that's fine. This looks good to me. I'll apply this while we are switching to 60.2.0esr, thanks.
Done with commit 7a88a4858db7fca96e126eba8fd0d0706bc36516 on master
.
The fix has been included in the esr60 branch:
https://bugzilla.mozilla.org/show_bug.cgi?id=1463749#c29
So this should be fixed in 60.2.