#27068 closed defect (fixed)

TOR_DIR shouldn't override CHUTNEY_TOR and CHUTNEY_TOR_GENCERT

Reported by: catalyst Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Chutney Version:
Severity: Normal Keywords:
Cc: teor Actual Points:
Parent ID: #27067 Points:
Reviewer: Sponsor:

Description

Right now, chutney's warnings when it can't find tor or tor-gencert suggest to set CHUTNEY_TOR and CHUTNEY_TOR_GENCERT. However, attempts to set these get overwritten by tools/test-network.sh with either a computed result based on TOR_DIR if that is set, or with plain program names to be searched in the path. This makes it harder to work around #27067.

Child Tickets

Change History (2)

comment:1 Changed 18 months ago by teor

Status: newneeds_review

I fixed this issue by making test-network.sh use CHUTNEY_TOR and CHUTNEY_TOR_GENCERT as binary paths if TOR_DIR is not a Tor build directory, rather than just searching PATH for the standard binary names.

This change allows CHUTNEY_TOR to be set as a workaround to #27067, even without the changes in #27067.

I also made the following changes:

  • If CHUTNEY_TOR or CHUTNEY_TOR_GENCERT aren't binary paths, use them as binary names to search PATH
  • Tell the user how chutney is trying to find tor binaries
  • Document chutney's binary search order better

I didn't swap the TOR_DIR and CHUTNEY_TOR search order, because (as far as I understand) chutney is mainly used in Tor build directories. And a major change like that could break compatibility with existing setups.

Please see the earlier commits in my branch bug27067 on https://github.com/teor2345/chutney.git

comment:2 Changed 18 months ago by nickm

Resolution: fixed
Status: needs_reviewclosed

merged parent

Note: See TracTickets for help on using tickets.