Opened 2 years ago

Closed 23 months ago

#27071 closed defect (fixed)

Stop using max_width=80 for rustfmt

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust
Cc: teor Actual Points:
Parent ID: #26972 Points:
Reviewer: Sponsor:

Description

We have two options:

  • use max_width=79 to match our C coding standards
  • use the default max_width=100 to match the Rust defaults and avoid wrapping bugs in rustfmt

For details, see:
https://trac.torproject.org/projects/tor/ticket/26972#comment:2
https://trac.torproject.org/projects/tor/ticket/26972#comment:3

Child Tickets

Change History (3)

comment:1 Changed 2 years ago by nickm

I favor copying the rust defaults here.

comment:2 Changed 2 years ago by teor

Ok, I'll ask for that fix in my #26972 review.

comment:3 Changed 23 months ago by teor

Resolution: fixed
Status: newclosed

Fixed in #26972.

Note: See TracTickets for help on using tickets.