Opened 7 weeks ago

Closed 6 weeks ago

Last modified 6 weeks ago

#27081 closed defect (fixed)

Don't link pthreads on win32, even if it is present

Reported by: nickm Owned by: nickm
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: fast-fix 029-backport 032-backport 033-backport 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

Some mingw setups include an -lpthread, even though we don't use pthreads on windows. Therefore, we should only search for the pthreads functions when we are not building for windows.

Child Tickets

Change History (6)

comment:1 Changed 7 weeks ago by nickm

Status: assignedneeds_review

Fix in my branch bug27081_029; PR at https://github.com/torproject/tor/pull/267

comment:2 Changed 6 weeks ago by asn

Reviewer: asn

comment:3 Changed 6 weeks ago by teor

(Looks fine to me, but I didn't run it on Windows, or check the appveyor build.)

comment:4 Changed 6 weeks ago by asn

Status: needs_reviewmerge_ready

LGTM!

comment:5 Changed 6 weeks ago by nickm

Resolution: fixed
Status: merge_readyclosed

ok; merged!

comment:6 Changed 6 weeks ago by heaslr

Tor Browser 8 is affected.

Note: See TracTickets for help on using tickets.