Opened 2 months ago

Closed 2 months ago

#27082 closed defect (fixed)

enable a limited UITour

Reported by: mcs Owned by: mcs
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201808R
Cc: tbb-team Actual Points:
Parent ID: #25695 Points:
Reviewer: Sponsor:

Description

For #25695, we plan to use Firefox's UITour implementation. However, in #19047, we disabled it for safety reasons. We will re-enable UITour but limit what it can do and which pages can use the functionality.

Child Tickets

Change History (4)

comment:1 Changed 2 months ago by mcs

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: assignedneeds_review

The following two commits address this ticket:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26961-01&id=2f6b711e5059c19b52895e6643d7f54289cb496f

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26961-01&id=53ac1b3c8fccac062f0121f3cacbb77cfdd77afb

(both are on a branch named bug26961-01 which also contain the additional commits needed for Desktop new user onboarding).

comment:2 Changed 2 months ago by gk

Those commits look good to me. I guess we could remove isTestingOrigin() as well as it is not used (anymore)?

comment:3 in reply to:  2 Changed 2 months ago by mcs

Replying to gk:

Those commits look good to me. I guess we could remove isTestingOrigin() as well as it is not used (anymore)?

You are right and done. Here are the new commits:
https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26961-03&id=bd51a3e4187e252a1b9ab3ec2fc714d7cd9a126c

https://gitweb.torproject.org/user/brade/tor-browser.git/commit/?h=bug26961-03&id=041bfe3d249ceb6c87d86d0c3d7c53aab16a8861

(branch bug26961-03).

comment:4 Changed 2 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good. Applied to tor-browser-60.1.0esr-8.0-1 (commits 99042436bbdae4d849902ddf49bb5e89311a5121 and fa471b46da2a188f02d2e120fd58224444aee818).

Note: See TracTickets for help on using tickets.