Opened 2 months ago

Closed 2 months ago

#27088 closed defect (implemented)

Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.4.1-alpha
Severity: Normal Keywords: not-just-linux, tor-ci, teor-was-assigned, 034-triage-20180328, 034-removed-20180328, 034-backport, 035-removed-20180711, fast-fix
Cc: dmr Actual Points:
Parent ID: #24629 Points:
Reviewer: catalyst Sponsor:

Description

Oops, it seems we missed this one.

Child Tickets

Change History (5)

comment:1 Changed 2 months ago by teor

Status: assignedneeds_review
Version: Tor: 0.3.4.1-alpha

This fix will be in my #24629 branch.

comment:2 Changed 2 months ago by asn

Reviewer: nickm

comment:3 Changed 2 months ago by asn

Reviewer: nickmcatalyst

comment:4 Changed 2 months ago by catalyst

Status: needs_reviewmerge_ready

Looks good! I'm not sure I like passing configure options that begin with -- as the first argument to echo. Maybe put some text that doesn't start with a dash first? Like echo configuring with flags $CONFIGURE_FLAGS?

On the other hand, I think the shells that Travis uses on all its platforms will tolerate it, so maybe we can let that remain.

comment:5 Changed 2 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Closing these because the parent (#24629) is now merged.

Note: See TracTickets for help on using tickets.