Pass MODULES_OPTIONS in DISTCHECK_CONFIGURE_FLAGS
Oops, it seems we missed this one.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.3.5.x-final
changed milestone to %Tor: 0.3.5.x-final
- teor added 034-backport 034-removed-20180328 034-triage-20180328 035-removed-20180711 component::core tor/tor fast-fix milestone::Tor: 0.3.5.x-final not-just-linux owner::teor parent::24629 priority::medium resolution::implemented reviewer::catalyst severity::normal status::closed teor-was-assigned tor-ci type::defect version::tor 0.3.4.1-alpha labels
added 034-backport 034-removed-20180328 034-triage-20180328 035-removed-20180711 component::core tor/tor fast-fix milestone::Tor: 0.3.5.x-final not-just-linux owner::teor parent::24629 priority::medium resolution::implemented reviewer::catalyst severity::normal status::closed teor-was-assigned tor-ci type::defect version::tor 0.3.4.1-alpha labels
This fix will be in my #24629 (moved) branch.
Trac:
Status: assigned to needs_review
Version: N/A to Tor: 0.3.4.1-alphaTrac:
Reviewer: N/A to nickmTrac:
Reviewer: nickm to catalystLooks good! I'm not sure I like passing configure options that begin with
--
as the first argument toecho
. Maybe put some text that doesn't start with a dash first? Likeecho configuring with flags $CONFIGURE_FLAGS
?On the other hand, I think the shells that Travis uses on all its platforms will tolerate it, so maybe we can let that remain.
Trac:
Status: needs_review to merge_readyClosing these because the parent (#24629 (moved)) is now merged.
Trac:
Resolution: N/A to implemented
Status: merge_ready to closed- Trac closed
closed
- Trac moved to tpo/core/tor#27088 (closed)
moved to tpo/core/tor#27088 (closed)