Opened 4 months ago

Closed 4 months ago

#27090 closed defect (implemented)

Travis: enable lzma and zstd in configure, if available

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.1.5-alpha
Severity: Normal Keywords: not-just-linux, tor-ci, teor-was-assigned, 034-triage-20180328, 034-removed-20180328, 034-backport, 035-removed-20180711, fast-fix
Cc: dmr Actual Points:
Parent ID: #24629 Points:
Reviewer: nickm Sponsor:

Description

Otherwise, we can break lzma or zstd detection without knowing it.

Child Tickets

Change History (5)

comment:1 Changed 4 months ago by teor

Status: assignedneeds_review
Version: Tor: 0.3.1.5-alpha

It turns out that we were never building with zstd on macOS, because the package config path wasn't set.

The fix will be in my #24629 branches.

comment:2 in reply to:  1 Changed 4 months ago by teor

Replying to teor:

It turns out that we were never building with zstd on macOS, because the package config path wasn't set.

The fix will be in my #24629 branches.

We were never installing the package, because "brew install" installs or updates.

comment:3 Changed 4 months ago by asn

Reviewer: nickm

comment:4 Changed 4 months ago by nickm

Status: needs_reviewmerge_ready

The patch (e4d7f2667c6c4660ad9663a39fbdef7d3e2961cd) looks plausible to me. Looking at the build logs on travis, I can confirm that Tor is detecting and building with zstd and lzma on OSX, and with lzma on ubuntu.

comment:5 Changed 4 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

Closing these because the parent (#24629) is now merged.

Note: See TracTickets for help on using tickets.