Opened 9 days ago

Closed 8 hours ago

#27096 closed defect (fixed)

Stop relying on $HOME being set in the unit tests

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords: tor-test
Cc: Actual Points:
Parent ID: Points:
Reviewer: asn Sponsor:

Description

When I test Tor with $HOME unset, I see the following error:

options/validate__uname_for_server: [forking] 
  FAIL ../src/test/test_options.c:507: expected log to not contain entries  Captured logs:
    1. warn: "Couldn\'t find $HOME environment variable while expanding \"~/.tor\"; defaulting to \"\".\n"
    2. warn: "Default DataDirectory is \"~/.tor\".  This expands to \"/.tor\", which is probably not what you want.  Using \"/usr/local/var/tor\" instead\n"

  [validate__uname_for_server FAILED]

This test has been around since 0.2.8.1-alpha.

Child Tickets

Change History (5)

comment:2 Changed 6 days ago by rl1987

Status: newneeds_review

comment:3 Changed 6 days ago by asn

Reviewer: asn

comment:4 Changed 3 days ago by asn

Status: needs_reviewmerge_ready

LGTM and works fine!

comment:5 Changed 8 hours ago by rl1987

Resolution: fixed
Status: merge_readyclosed

Was merged recently (d029a5162d0f2a3255630500f9c81cc4f7bdc103).

Note: See TracTickets for help on using tickets.