Add "Tor News" newsletter signup link in Tor Browser
As part of our community building and fundraising, we would like to add a link to make it easy for users to join Tor's email list. We'll need final text, a URL, and a design.
Activity
I believe the URL we want is https://newsletter.torproject.org/
Trac:
Summary: "Join the Tor email list!" link in Tor Browser to Add "Tor News" newsletter signup link in Tor BrowserWe discussed at length among Tor members and settled on the following text:
Get the latest news from Tor straight to your inbox. Sign up for Tor News.Here's a patch for review that adds that text. We would like to land this soon to allow translation to get started:
https://github.com/arthuredelstein/torbutton/commit/27097
Trac:
Status: new to needs_review
Keywords: N/A deleted, TorBrowserTeam201808R added
hey!
I explored Firefox's Snippets and seems to be the best option for this feature https://wiki.mozilla.org/Firefox/Projects/Firefox_Start/Snippet_Service
I made some versions with different background color and position. If it takes a lot of time and we need to have it soon, I made a version with the link at the
bottom.Please, let me know what do you think!
Hi Antonela,
Is it possible to have a top - white copy one with the colors shifted? Like instead of white copy a purple one and the background is white? I really would like to keep the envelope icon tho, not sure if that is only in white.
I feel we all the bottom ones very hard to even notice they are there, I would not use them.
-
Yes! I used a white background and made a custom icon with and without color.
How does it look now?
https://marvelapp.com/42g2bae/screen/47067924 https://marvelapp.com/42g2bae/screen/47067925
-
Cool, Sarah and Steph approved it via email. https://trac.torproject.org/projects/tor/attachment/ticket/27097/TB8%20-%20Snippet%20-%20Top%20-%20White%20-%20Icon%20Color.png
Assets are ready here https://marvelapp.com/42g2bae/screen/47067924/handoff
thanks all!
-
Trac:
assets.zip Replying to gk:
That's just been the two strings, right? At any rate, I pushed those to
master(commit 3e7502789eca79d2e73c82b65770fc0d08527584). Setting the state tonewagain for the remaining things.I have just discovered that
aboutTor.propertiesis no longer usable in about:tor, as a result of the patch from #26960 (moved) implementing our awesome new about:tor page. So here is a patch to move the two strings toaboutTor.dtdand remove the rest ofaboutTor.propertiesfile in each locale (I will ensure that any already-translated instances of the two "newsletter" strings are moved to the new location in Transifex.):https://github.com/arthuredelstein/torbutton/commit/27097+2
Edit: new revision
Here's an implementation patch for review:
https://github.com/arthuredelstein/torbutton/commit/27097+3
And here is a screenshot:
Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201808R added
The code looks okay, but I am not happy with the behavior yet. So, the user get urged to subscribe to Tor News which I am generally fine with. However, I think it is bad behavior to still urge someone to subscribe somewhere after they already had or after they already made the decision to not subscribe (for whatever reasons). But the current patch does that as the banner is not going away. Now, that's hard to do without knowing the intentions or the one using the browser but one can simulate that by showing the banner only on first start or a small amount of times after first start. I think we should do something like that.
From a design perspective I am not happy either as the design at the top is drawing attention away from the onboarding we developed for 8.0. I think the onboarding is one of the major improvements for Tor Browser usability but right now once Tor Browser starts I fear users are only seeing the white banner (and might get annoyed by it because it does not go away).
Trac:
Status: needs_review to needs_revision-
Trac:
Cc: sstevenson@torproject.org, antonela, tbb-team to sstevenson@torproject.org, antonela, tbb-team, isabela -
Hi there,
I agree that our new user experience should have some momentum before we distract people with the banner.
Here is the calendar for what goes out and when:
09.05 - 8.0 stable release goes out without the newsletter banner
Before 09.28 Mexico meeting - we will probably need to do a bug fixing release, so the newsletter banner will go out with that release.
The experience from Firefox that this banner is based on does include an X for the user to close it. The X shows up when your mouse hoover over the banner. Can devs confirm that with me? I want to make sure there is a way for the user to close the banner (or express 'no').
10.23 stable release - Is when our YE campaign banner will go out.
Replying to gk:
The code looks okay, but I am not happy with the behavior yet. So, the user get urged to subscribe to Tor News which I am generally fine with. However, I think it is bad behavior to still urge someone to subscribe somewhere after they already had or after they already made the decision to not subscribe (for whatever reasons). But the current patch does that as the banner is not going away. Now, that's hard to do without knowing the intentions or the one using the browser but one can simulate that by showing the banner only on first start or a small amount of times after first start. I think we should do something like that.
From a design perspective I am not happy either as the design at the top is drawing attention away from the onboarding we developed for 8.0. I think the onboarding is one of the major improvements for Tor Browser usability but right now once Tor Browser starts I fear users are only seeing the white banner (and might get annoyed by it because it does not go away).
Hi gk and isabela,
I agree with your points here. The code currently doesn't have an X to close the banner, but we can add one. And I think you're right we should wait for a later release to post this banner.
I think we could also consider a design in the future where the newsletter link is not so prominent but integrated better with the about:tor design. For example, it could look similar to the Tor Browser Manual link. That way we could include the newsletter link permanently without distracting from the more important elements in the design (such as the onboarding, the "Explore. Privately." tagline and the search box).
-
I think we could also consider a design in the future where the newsletter link is not so prominent but integrated better with the about:tor design. For example, it could look similar to the Tor Browser Manual link. That way we could include the newsletter link permanently without distracting from the more important elements in the design (such as the onboarding, the "Explore. Privately." tagline and the search box).
arthur yes, I agreed. I made a version here on the first round of iterations with that option. Maybe, we can discuss it with comms people too. They have another idea about how to use
about:tor. Replying to antonela:
arthur yes, I agreed. I made a version here on the first round of iterations with that option. Maybe, we can discuss it with comms people too. They have another idea about how to use
about:tor.I think this is a good approach. Here's a patch that does that: https://github.com/arthuredelstein/torbutton/commit/27097+4
And here is the screenshot:
Here's a new version of the banner for review. It disappears permanently:
- if the user clicks a small "X" on the right
- if the user clicks the "Sign Up" link
- if the banner has already been shown 4 times https://github.com/arthuredelstein/torbutton/commit/27097+5
Trac:
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201809R added
Status: needs_revision to needs_review-
Looks good! One small thing:
+ const kAboutTorHideTorNewsBanner = this.kAboutTorHideTorNewsBanner;just remove that line and use
this.kAboutTorHideTorNewsBannerin the two instances needed directly. Having akAboutTorHideTorNewsBannerin the function scope and declared above is confusing and seems not worth it.Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201809R deleted, TorBrowserTeam201809 added Replying to gk:
Thanks for the review!
Looks good! One small thing: {{{
- const kAboutTorHideTorNewsBanner = this.kAboutTorHideTorNewsBanner;
}}}
just remove that line and use
this.kAboutTorHideTorNewsBannerin the two instances needed directly. Having akAboutTorHideTorNewsBannerin the function scope and declared above is confusing and seems not worth it.
Good catch. Here's a revised version where I fix that and rebased to the latest master.
- const kAboutTorHideTorNewsBanner = this.kAboutTorHideTorNewsBanner;
}}}
just remove that line and use
-
Ha, so it seems we got the scope of "this" wrong. I have a follup-up fix for that issue in my
bug_27097-fixup(https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_27097-fixup&id=7540556c69566bc5454be354d877d08b98ac5d99). Arthur, please review.Trac:
Status: closed to reopened
Resolution: fixed to N/A
