#27124 closed defect (fixed)

Reading node statuses pointlessly initialises first seen millis as last seen millis

Reported by: irl Owned by: irl
Priority: Medium Milestone:
Component: Metrics/Onionoo Version:
Severity: Normal Keywords:
Cc: metrics-team Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

      long firstSeenMillis = lastSeenMillis;
      firstSeenMillis = DateTimeHelper.parse(parts[15] + " " + parts[16]);

https://gitweb.torproject.org/onionoo.git/tree/src/main/java/org/torproject/onionoo/docs/NodeStatus.java#n568

Maybe this was done for a reason and later broken, or maybe it was never needed.

Child Tickets

Change History (4)

comment:1 Changed 11 months ago by karsten

Sure, those two lines can be merged into a single one.

comment:2 Changed 11 months ago by irl

Cc: metrics-team added
Owner: changed from metrics-team to irl
Status: newaccepted

comment:3 Changed 11 months ago by irl

Status: acceptedneeds_review

Please review trivial commit 6c94482 in my task/27124 branch.

Checks and tests pass.

Last edited 11 months ago by irl (previous) (diff)

comment:4 Changed 11 months ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Looks good, merged. Closing. Thanks!

Note: See TracTickets for help on using tickets.