Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#27129 closed defect (fixed)

Add ca, ga, id, is, nb locales for Tor Browser

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-localization, TorBrowserTeam201808R, ff60-esr
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

According to our monitoring at https://torpat.ch/locales, these 5 locales are 100% translated.

Child Tickets

Change History (6)

comment:1 Changed 3 months ago by arthuredelstein

Summary: Add ca, ga, id, nb, pt locales for Tor BrowserAdd ca, ga, id, is, nb locales for Tor Browser

We have 7 that are at 100% or 99% translated: bn-BD, ca, ga, id, is, nb, pt.

bn-BD has a strange bug, and pt is lower priority because we already have pt-BR. So I'd propose for our next batch of new locales we add ca, ga, id, is, nb.

comment:2 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam2018R added
Status: newneeds_review

Here are patches for review:

https://github.com/arthuredelstein/torbutton/commit/27129
https://github.com/arthuredelstein/tor-launcher/commit/27129
https://github.com/arthuredelstein/tor-browser-build/commit/27129

I'm still awaiting the results of a build, but I did a manual test with langpacks and all 5 locales worked.

comment:3 Changed 3 months ago by arthuredelstein

I built all 5 locales for linux-x86_64 and confirmed the browsers all work and the text is rendered in their respective languages.

(After merging these patches for torbutton and tor-launcher we'll need to run ./import-translations.sh again and commit the results to make sure the translation strings for those locales are properly imported.)

comment:4 Changed 3 months ago by arthuredelstein

Keywords: TorBrowserTeam201808R ff60-esr added; TorBrowserTeam2018R removed

comment:5 in reply to:  2 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to arthuredelstein:

Here are patches for review:

https://github.com/arthuredelstein/torbutton/commit/27129
https://github.com/arthuredelstein/tor-launcher/commit/27129
https://github.com/arthuredelstein/tor-browser-build/commit/27129

I'm still awaiting the results of a build, but I did a manual test with langpacks and all 5 locales worked.

Patches look good. Applied to torbutton (commit 859160f4d23a2706c4cad689c5379a33b0070ef5), tor-launcher (commit 0fb1ea7e8ec9b118c1aa08f92fef7cb7b47cb4ea), and tor-browser-build (commit ad4233157674808d5d8557ada5ce97a145d8a3e5).

comment:6 Changed 3 months ago by gk

Resolved #26458 as duplicate.

Note: See TracTickets for help on using tickets.