Opened 9 months ago

Last modified 2 months ago

#27161 assigned enhancement

Add make check-rustfmt to make check

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, rustfmt, 040-can, teor-unreached-2019-03-08
Cc: Actual Points:
Parent ID: #27908 Points:
Reviewer: Sponsor: SponsorV-can

Description

In #26972, we discovered that stable and nightly rustfmt disagree about the formatting of some of Tor's Rust code. Beta currently follows nightly.

On 13 September, the current beta branch will become stable, and the formatting differences should go away. (Rust releases happen every 6 weeks, and the last one was on 2 August 2018: https://github.com/rust-lang/rust/blob/master/RELEASES.md .)

Here's what we need to do:

Child Tickets

Change History (4)

comment:1 Changed 7 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:2 Changed 3 months ago by dgoulet

Keywords: 040-can added
Priority: MediumLow

Bug triage of 0.4.0 tickets. These are now in the "CAN" section. Lower priority than "040-must".

comment:3 Changed 2 months ago by teor

Parent ID: #27908

We should do this when we move privcount_shamir into tor in #29009, or when we start writing PrivCount Rust in #27908.

comment:4 Changed 2 months ago by teor

Keywords: teor-unreached-2019-03-08 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified
Owner: teor deleted
Sponsor: SponsorV-can
Type: defectenhancement

Remove a low-priority task.

Note: See TracTickets for help on using tickets.