Opened 6 weeks ago

Closed 5 weeks ago

#27177 closed defect (fixed)

rust protover accepts tabs and newlines in protocol versions

Reported by: cyberpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.3.3.9
Severity: Normal Keywords: rust, 033-backport, 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

"Desc=1\t,2" is considered fine, and so are any of these other characters: https://en.wikipedia.org/wiki/Whitespace_character#Unicode which protover.c doesn't understand.

Child Tickets

Change History (5)

comment:1 Changed 6 weeks ago by cyberpunks

Patch on branch rust-protospace at ​​​https://gitgud.io/onionk/tor.git

comment:2 Changed 6 weeks ago by teor

Milestone: Tor: 0.3.5.x-final
Status: newneeds_revision

Thanks for this patch, it looks good to me.

Here's what needs to change before it merges:

  • code changes need a changes file that passes make check-changes
    • (doc and comment changes don't get a changes file)
  • the branch needs to be rebased onto maint-0.3.3

Let us know if you don't want to make these changes, and someone else will do them eventually.

And also:

comment:3 Changed 6 weeks ago by teor

This branch passed CI.

comment:4 in reply to:  2 Changed 5 weeks ago by cyberpunks

Replying to teor:

  • the branch needs to be rebased onto maint-0.3.3

Done.

comment:5 Changed 5 weeks ago by nickm

Resolution: fixed
Status: needs_revisionclosed

Looks good; merged to 0.3.3 and forward!

Note: See TracTickets for help on using tickets.