Generating of incremental MAR files fails due to new compression format

Generating the incremental MAR files for Tor Browser 8.0a10 fails as the script does not know about the new compression format. I guess while we are still in the transitioning period it could check both formats making sure the new format is getting used when recompressing things.

added TorBrowserTeam201808R component::applications/tor browser owner::tbb-team parent::26050 priority::very high resolution::fixed severity::normal status::closed tbb-rbm type::defect labels

There is a patch for review in branch bug_27178, adding an option to select the format: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_27178&id=93acbf12b01c83facfb6fb023ceff10d9f601b98

We are not checking that xz is used in the generated incrementals as this would require extracting them again after they are created. But we are using the mar-tools from the new version, and MAR_OLD_FORMAT is not set, so I think it should get used.

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201808 deleted, TorBrowserTeam201808R added

Replying to boklm:

We are not checking that xz is used in the generated incrementals as this would require extracting them again after they are created. But we are using the mar-tools from the new version, and MAR_OLD_FORMAT is not set, so I think it should get used.

After manually extracting one of the generated incremental, I see that the files are indeed compressed with xz.

Works for me. Applied to master (commit 93acbf12b01c83facfb6fb023ceff10d9f601b98). We should file follow-up bugs to adapt this patch during the whole watershed thing (and mark those bugs as child bugs for #26050 (moved)). I'll file the one for 8.0a10->8.0a11 (or 8.0a10-8.5a1 if 8.0a10 will be the last alpha) incremental creation.

Trac:
Parent: N/A to #26050 (moved)
Resolution: N/A to fixed
Status: needs_review to closed

I filled #27182 (moved) and #27183 (moved) for the 8.0.1 and 8.0.2 updates.

closed

mentioned in issue #27179 (moved)

mentioned in issue #27182 (moved)

mentioned in issue #27183 (moved)

moved to tpo/applications/tor-browser#27178 (closed)

mentioned in issue tpo/applications/tor-browser#27179 (closed)

mentioned in issue tpo/applications/tor-browser#27182 (closed)

mentioned in issue tpo/applications/tor-browser#27183 (closed)