Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#27178 closed defect (fixed)

Generating of incremental MAR files fails due to new compression format

Reported by: gk Owned by: tbb-team
Priority: Very High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, TorBrowserTeam201808R
Cc: boklm Actual Points:
Parent ID: #26050 Points:
Reviewer: Sponsor:

Description

Generating the incremental MAR files for Tor Browser 8.0a10 fails as the script does not know about the new compression format. I guess while we are still in the transitioning period it could check both formats making sure the new format is getting used when recompressing things.

Child Tickets

Change History (4)

comment:1 Changed 4 months ago by boklm

Keywords: TorBrowserTeam201808R added; TorBrowserTeam201808 removed
Status: newneeds_review

There is a patch for review in branch bug_27178, adding an option to select the format:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_27178&id=93acbf12b01c83facfb6fb023ceff10d9f601b98

We are not checking that xz is used in the generated incrementals as this would require extracting them again after they are created. But we are using the mar-tools from the new version, and MAR_OLD_FORMAT is not set, so I think it should get used.

comment:2 in reply to:  1 Changed 4 months ago by boklm

Replying to boklm:

We are not checking that xz is used in the generated incrementals as this would require extracting them again after they are created. But we are using the mar-tools from the new version, and MAR_OLD_FORMAT is not set, so I think it should get used.

After manually extracting one of the generated incremental, I see that the files are indeed compressed with xz.

comment:3 Changed 4 months ago by gk

Parent ID: #26050
Resolution: fixed
Status: needs_reviewclosed

Works for me. Applied to master (commit 93acbf12b01c83facfb6fb023ceff10d9f601b98). We should file follow-up bugs to adapt this patch during the whole watershed thing (and mark those bugs as child bugs for #26050). I'll file the one for 8.0a10->8.0a11 (or 8.0a10-8.5a1 if 8.0a10 will be the last alpha) incremental creation.

comment:4 Changed 4 months ago by boklm

I filled #27182 and #27183 for the 8.0.1 and 8.0.2 updates.

Note: See TracTickets for help on using tickets.