Opened 3 months ago

Closed 3 months ago

#27179 closed defect (fixed)

Adapt patch written in bug 27178 (different compression algorithms) for update from 8.0a10 to next alpha release

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: ff60-esr, TorBrowserTeam201809R
Cc: boklm Actual Points:
Parent ID: #26050 Points:
Reviewer: Sponsor:

Description

We needed to patch our incremental MAR generation script to be able to handle different compression algorithms simultaneously (done in #27178). We need to adapt that patch to handle future alpha updates.

Child Tickets

Change History (9)

comment:1 Changed 3 months ago by boklm

There is a patch for this in branch bug_27179, to be merged after 8.0a10 is released:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_27179&id=df4e295be78776d9aa2ce7142cfac951359438d8

comment:2 Changed 3 months ago by gk

Summary: Adapt patch written in bug 27178 for update from 8.0a10 to next alpha releaseAdapt patch written in bug 27178 (different compression algorithms) for update from 8.0a10 to next alpha release

comment:3 Changed 3 months ago by gk

The suggestion was that ANGLE is broken (at least according to the original bug report in our blog: https://blog.torproject.org/comment/275959#comment-275959).

comment:4 Changed 3 months ago by gk

Priority: MediumHigh

Bump prio.

comment:5 in reply to:  3 ; Changed 3 months ago by boklm

Replying to gk:

The suggestion was that ANGLE is broken (at least according to the original bug report in our blog: https://blog.torproject.org/comment/275959#comment-275959).

Hmm, that seems unrelated to the type of compression used in the mar files. Was this comment intended for a different ticket?

comment:6 in reply to:  5 Changed 3 months ago by gk

Replying to boklm:

Replying to gk:

The suggestion was that ANGLE is broken (at least according to the original bug report in our blog: https://blog.torproject.org/comment/275959#comment-275959).

Hmm, that seems unrelated to the type of compression used in the mar files. Was this comment intended for a different ticket?

Indeed. It was meant for #27290.

comment:7 Changed 3 months ago by gk

Keywords: TorBrowserTeam201809R added; TorBrowserTeam201808 removed

comment:8 Changed 3 months ago by boklm

Status: newneeds_review

Branch bug_27179_v2 has the same patch as bug_27179 rebased on master:
https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_27179_v2&id=2741dc7c1a6200c97be4e91e20629673b1d83d9d

It should handle correctly stable/alpha branches, so I think can be merged now.

comment:9 Changed 3 months ago by gk

Resolution: fixed
Status: needs_reviewclosed

Thanks. I actually went ahead with cherry-picking the commit in your bug_27179 branch before seeing the rebase, sorry. Anyway, commit 8955afc1fb84a191268219b7f4c28050585b791a on master has the changes.

Note: See TracTickets for help on using tickets.