Remove DetailsDocumentFields interface

This interface "Provides constants for details document field names".

In practice, it only provides 2 of them, and they're only used in one function that is full of other hard coded strings.

We can remove this to reduce complexity.

added component::metrics/onionoo owner::irl priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

Trac:
Owner: metrics-team to irl
Status: new to accepted

Or can we use it for the remaining fields, too? If not, I'm okay with removing this interface.

Aaah, it is also used to build the OrderParameters. Now I'm unsure if we would want to remove this, or go the other direction and use it for all parameters in the documents.

Please review my [41c9a9b in my task/27180 branch] to see what removing it looks like. Maybe this can help us decide which way to go.

Trac:
Status: accepted to needs_review

Trac:
Cc: N/A to metrics-team

I think it's okay to just remove it.

In fact, regarding OrderParameters, I think that these shouldn't use DetailsDocumentFields anyway, because parameter values and document fields are not necessarily the same thing. They happen to be the same in this case, and in most cases that makes sense, but there might be cases where they are not.

Should I merge this change then?

Yes. There are no user facing or operational changes so I don't think this needs a changelog entry.

Merged. Closing. Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed