Inform users about configuration file and directory includes

This patch makes it clearer to users what settings Tor daemon is actually using. I think it is pretty important.

https://github.com/UntoSten/tor/tree/inform-about-conf-includes

Trac:
Username: UntoSten

changed milestone to %Tor: 0.4.4.x-final

added backport component::core tor/tor milestone::Tor: 0.4.4.x-final priority::low reporter::UntoSten resolution::fixed reviewer::dgoulet severity::minor status::closed type::enhancement labels

Trac:
Status: new to needs_review
Milestone: N/A to Tor: 0.3.5.x-final

This seems useful. lgtm;

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready

added a changes file and merged. I think we'll want to tweak the wording over time, but having this message is a strict improvement over not having it.

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

I've made some small changes to this feature:

• Changed the wording a bit
• Move the existing log line before the %include is handled. In case of error in a recursive include, this makes the messages appear in ascending order of recursion level, which makes more sense than the opposite.
• Added a extra log line for each file that is actually included (the existing log line only shows the %include paths in the config files). This will show the actual included files when the %include path is a folder.

Pull request: https://github.com/torproject/tor/pull/1886

Trac:
Status: closed to reopened
Resolution: implemented to N/A

Trac:
Status: reopened to needs_review

Trac:
Milestone: Tor: 0.3.5.x-final to Tor: 0.4.4.x-final
Keywords: N/A deleted, backport added

After the CI tests run on my pull request, they failed because some of the tests expect the previous string. I've updated the tests.

lgtm

Trac:
Status: needs_review to merge_ready

Merged

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved to tpo/core/tor#27186 (closed)