Opened 16 months ago
Last modified 11 months ago
#27189 needs_revision task
cleanup rust code
Reported by: | cyberpunks | Owned by: | |
---|---|---|---|
Priority: | Medium | Milestone: | Tor: unspecified |
Component: | Core Tor/Tor | Version: | |
Severity: | Normal | Keywords: | rust, 035-deferred-20190115, 041-proposed |
Cc: | chelseakomlo | Actual Points: | |
Parent ID: | Points: | ||
Reviewer: | Sponsor: |
Description
There are low-hanging fruit for silencing clippy lints, removing unnecessary allocations, and writing a more efficient version of .retain()
.
Child Tickets
Change History (8)
comment:1 Changed 16 months ago by
comment:2 Changed 16 months ago by
Milestone: | → Tor: 0.3.5.x-final |
---|---|
Status: | new → needs_review |
comment:3 Changed 16 months ago by
comment:4 follow-up: 7 Changed 16 months ago by
Thanks for the patch. Looking over the commits on this branch, it looks like there are a lot of small changes and several refactoring commits (For example,renaming functions, etc). Can you please separate this ticket into more specific tickets/patches? For example, I recommend creating a ticket for Clippy fixups, a separate ticket for creating a more efficient .retain()
, etc. This will help us more effectively and quickly review these changes.
To organize these, feel free to keep this issue as the parent ticket with sub-tickets for each change.
comment:5 Changed 16 months ago by
Status: | needs_review → needs_revision |
---|
comment:6 Changed 16 months ago by
Cc: | chelseakomlo added |
---|
comment:7 Changed 16 months ago by
Replying to chelseakomlo:
a separate ticket for creating a more efficient
.retain()
,
That one's #27206, which nobody has reviewed yet still.
comment:8 Changed 11 months ago by
Keywords: | 035-deferred-20190115 041-proposed added |
---|---|
Milestone: | Tor: 0.3.5.x-final → Tor: unspecified |
Marking a number of 0.3.5 tickets as possible, maybe even a good idea, for later. Possibly backportable, some of them. But not currently things to do as part of 0.3.5 stabilization.
Branch rust-cleanup1 at https://gitgud.io/onionk/tor.git