Changes between Version 1 and Version 2 of Ticket #27189, comment 4


Ignore:
Timestamp:
Aug 27, 2018, 3:42:50 PM (13 months ago)
Author:
chelseakomlo
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27189, comment 4

    v1 v2  
    1 Thanks for the patch. Looking over the commits on this branch, it looks like there are a lot of small changes and several refactoring commits (For example,renaming functions, etc). Can you please separate this ticket into more specific tickets/patches? For example, I recommend creating a ticket for Clippy fixups, a separate ticket for creating a more efficient `.retail()`, etc. This will help us more effectively and quickly review these changes.
     1Thanks for the patch. Looking over the commits on this branch, it looks like there are a lot of small changes and several refactoring commits (For example,renaming functions, etc). Can you please separate this ticket into more specific tickets/patches? For example, I recommend creating a ticket for Clippy fixups, a separate ticket for creating a more efficient `.retain()`, etc. This will help us more effectively and quickly review these changes.
    22
    33To organize these, feel free to keep this issue as the parent ticket with sub-tickets for each change.