#27195 closed enhancement (implemented)

Rust: add tests for protover edge cases

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 033-backport, 034-backport, rust, tor-test
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

There are more tests for #27164 and #27177 in branch prototest1 on ​https://gitgud.io/onionk/tor.git

Since we backported the fixes, I suggest we backport the tests.

Original comment:
https://trac.torproject.org/projects/tor/ticket/27164#comment:7

Child Tickets

Change History (5)

comment:1 Changed 12 months ago by teor

Status: newneeds_review

comment:2 Changed 12 months ago by chelseakomlo

These extra test cases look good to me. Ideally we would write some kind of fuzzer test for this kind of string-parsing/handling code, but for this particular change it looks good to merge in.

Setting this as merge-ready so Nick can take a look.

comment:3 Changed 12 months ago by chelseakomlo

Status: needs_reviewmerge_ready

comment:4 Changed 12 months ago by nickm

Added to github as https://github.com/torproject/tor/pull/295 for CI. Will merge once CI passes.

comment:5 Changed 12 months ago by nickm

Resolution: implemented
Status: merge_readyclosed

CI passed; branch merged!

Note: See TracTickets for help on using tickets.