Opened 6 months ago

Last modified 6 months ago

#27199 needs_information defect

panic inside rust extern "C" function is undefined behavior

Reported by: cyberpunks Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rust, 033-backport, 034-backport
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

panic="abort" needs to be set for all profiles in Cargo.toml, at least until the upstream bug is fixed: https://github.com/rust-lang/rust/issues/52652

This is already set for [profile.release] builds, but not for the others.

Child Tickets

Change History (5)

comment:1 Changed 6 months ago by cyberpunks

See the rust-panic1 branch at ​​​​https://gitgud.io/onionk/tor.git

Last edited 6 months ago by cyberpunks (previous) (diff)

comment:2 Changed 6 months ago by nickm

Milestone: Tor: 0.3.5.x-final
Status: newneeds_review

comment:3 Changed 6 months ago by chelseakomlo

This change looks ok to me (I can't think of a use case when we would want to allow for unwinding as opposed to aborting).

Did you manually test this change with the different builds (test, bench, etc) to ensure that the project still builds successfully?

Last edited 6 months ago by chelseakomlo (previous) (diff)

comment:4 Changed 6 months ago by chelseakomlo

Status: needs_reviewneeds_information

comment:5 Changed 6 months ago by chelseakomlo

It would be helpful for these PRs to have Travis run against them so we can see how this impacts tor builds- I'm waiting for feedback from other network team members if there is a non-github alternative, but ideally with these PRs we could also see the build status.

Note: See TracTickets for help on using tickets.