Opened 8 months ago

Last modified 7 weeks ago

#27201 needs_information defect

rust/protover doesn't forbid version zero

Reported by: cyberpunks Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: 0.3.3.1-alpha
Severity: Normal Keywords: rust, 034-backport, 035-backport, postfreeze-ok, 040-deferred-20190220, 033-backport-unreached
Cc: Actual Points:
Parent ID: #27198 Points:
Reviewer: teor Sponsor:

Description

Per the spec, version integers can't begin with, or be, zero:

       Int = NON_ZERO_DIGIT
       Int = Int DIGIT

Child Tickets

Change History (14)

comment:1 Changed 8 months ago by cyberpunks

See the rust-protozero1 branch at ​​​​https://gitgud.io/onionk/tor.git

comment:2 Changed 8 months ago by nickm

Milestone: Tor: 0.3.5.x-final
Status: newneeds_review

comment:3 Changed 7 months ago by asn

Reviewer: teor

comment:5 Changed 6 months ago by teor

Keywords: 035-backport added
Milestone: Tor: 0.3.5.x-finalTor: 0.3.6.x-final
Status: needs_reviewneeds_revision

This branch seems to have a lot of unrelated changes in it.

Can you please cherry-pick the "zero" changes on top of master?
If you can't, just let us know, and we will do it eventually.

comment:6 in reply to:  5 Changed 6 months ago by cyberpunks

Branch is rebased. Other changes were mostly actually already merged between August and now.

Last edited 6 months ago by cyberpunks (previous) (diff)

comment:7 Changed 6 months ago by nickm

Status: needs_revisionneeds_review

comment:8 Changed 6 months ago by teor

Status: needs_reviewneeds_information

The CI is here:
https://github.com/torproject/tor/pull/456

But we need to resolve the spec questions in:
https://trac.torproject.org/projects/tor/ticket/27198#comment:7
Before we can merge this branch.

comment:9 Changed 6 months ago by teor

The CI passed when merging to 0.3.3.

Once we've resolved the spec questions, I can do a merge forward to 0.3.4/0.3.5/master, and run CI on that as well.

comment:10 Changed 5 months ago by nickm

Milestone: Tor: 0.3.6.x-finalTor: 0.4.0.x-final

Tor 0.3.6.x has been renamed to 0.4.0.x.

comment:11 Changed 3 months ago by nickm

Keywords: postfreeze-ok added

Mark some tickets as postfreeze-ok, to indicate that I think they are okay to accept in 0.4.0 post-freeze. Does not indicate that they are all necessary to do postfreeze.

comment:12 Changed 2 months ago by nickm

Keywords: 040-deferred-20190220 added
Milestone: Tor: 0.4.0.x-finalTor: unspecified

Deferring 51 tickets from 0.4.0.x-final. Tagging them with 040-deferred-20190220 for visibility. These are the tickets that did not get 040-must, 040-can, or tor-ci.

comment:13 Changed 7 weeks ago by teor

Keywords: 033-backport removed

These open, non-merge_ready tickets can not get backported to 0.3.3, because 0.3.3 is now unsupported.

comment:14 Changed 7 weeks ago by teor

Keywords: 033-backport-unreached added

Hmm, I guess they should still get 033-backport-unreached

Note: See TracTickets for help on using tickets.