Opened 14 months ago

Closed 13 months ago

Last modified 13 months ago

#27205 closed defect (implemented)

add unit test for double-voting

Reported by: cypherpunks3 Owned by:
Priority: Medium Milestone: Tor: 0.3.5.x-final
Component: Core Tor/Tor Version: Tor: 0.2.9.4-alpha
Severity: Normal Keywords: protover
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

protover.c has a comment about very important code that guards against double-voting:

  smartlist_sort_strings(expanded);
  smartlist_uniq_strings(expanded); // This makes voting work. do not remove

But no test fails if this is removed.

Child Tickets

Change History (3)

comment:1 Changed 14 months ago by cypherpunks3

See branch doublevote1 at ​​​​​https://gitgud.io/onionk/tor.git

comment:2 Changed 14 months ago by nickm

Milestone: Tor: 0.3.5.x-final
Status: newneeds_review

comment:3 Changed 13 months ago by nickm

Resolution: implemented
Status: needs_reviewclosed

lgtm; merged to master.

Note: See TracTickets for help on using tickets.