Opened 12 months ago

Closed 6 months ago

#27210 closed enhancement (fixed)

TBA - Support i386 target

Reported by: sysrqb Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-mobile, tbb-rbm, TBA-a3, GeorgKoppen201902, TorBrowserTeam201903R
Cc: boklm, sisbell Actual Points:
Parent ID: #5709 Points:
Reviewer: Sponsor: Sponsor8

Description

We should add support for the x86 target. As far as I can see, this requires a separate build.

We may want a separate .mozconfig for this. Maybe we can keep the shared config lines into .mozconfig-android, and put the different targets and objdirs into .mozconfig-android-x86 and .mozconfig-android-arm.

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-arm-linux-androideabi                                                                                                                                                    
ac_add_options --target=arm-linux-androideabi
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/obj-x86-linux-androideabi                                                                                                                                                    
ac_add_options --target=i386-linux-android

When running mach configure for i386, we'll need:
rustup target add i686-linux-android and we'll need to install yasm (apt install yasm).

Child Tickets

Change History (16)

comment:1 Changed 12 months ago by sysrqb

Parent ID: #25696#5709

We don't need this for the first alpha (or any of its child tickets).

comment:2 Changed 8 months ago by gk

Cc: boklm sisbell added; tbb-team removed
Keywords: tbb-rbm TorBrowserTeam201812 added

comment:3 Changed 8 months ago by gk

#28118 is a duplicate.

comment:4 Changed 8 months ago by gk

Keywords: TBA-a3 added

Setting tag for third Tor Browser for Android alpha milestone.

comment:5 Changed 8 months ago by gk

Priority: MediumHigh

comment:6 Changed 8 months ago by gk

Sponsor: Sponsor8

+ 2 for sponsor8.

comment:7 Changed 7 months ago by gk

Keywords: TorBrowserTeam201901 added; TorBrowserTeam201812 removed

Moving tickets to Jan 2019.

comment:8 Changed 6 months ago by gk

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201901 removed

Moving tickets to February.

comment:9 Changed 6 months ago by gk

Keywords: GeorgKoppen201902 added

comment:10 Changed 6 months ago by gk

Okay, that was surprisingly easy it seems. I have a patch which I'll clean up tomorrow for review and will post a test bundle for folks with access to x86 android.

comment:12 Changed 6 months ago by watt

Where did you get --disable-rust-debug?

comment:13 in reply to:  11 ; Changed 6 months ago by boklm

Keywords: TorBrowserTeam201902 added; TorBrowserTeam201902R removed
Status: needs_reviewneeds_revision

Replying to gk:

Alright. bug_27210_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27210_v2&id=de71da3ce100983cbd20f4a7ce2c0d37492e2669) has the patch for review.

  • in projects/android-toolchain/build, I am wondering if instead of installing just the architecture we need, we could install all architectures we support, and share the toolchain between all the architectures. This would save some space on the disk, but maybe also slow down a little the build as we would be extracting archs we don't need. The extracted android-toolchain archive is currently 4.8G, of which 985M is the arm directory.
  • in projects/rust/build, the patch 0001-Make-sure-dl_iterate_phdr-is-undefined-on-Android.patch is applied twice for the android-armv7 build.

comment:14 in reply to:  13 ; Changed 6 months ago by gk

Keywords: TorBrowserTeam201902R added; TorBrowserTeam201902 removed
Status: needs_revisionneeds_review

Replying to boklm:

Replying to gk:

Alright. bug_27210_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27210_v2&id=de71da3ce100983cbd20f4a7ce2c0d37492e2669) has the patch for review.

  • in projects/android-toolchain/build, I am wondering if instead of installing just the architecture we need, we could install all architectures we support, and share the toolchain between all the architectures. This would save some space on the disk, but maybe also slow down a little the build as we would be extracting archs we don't need. The extracted android-toolchain archive is currently 4.8G, of which 985M is the arm directory.
  • in projects/rust/build, the patch 0001-Make-sure-dl_iterate_phdr-is-undefined-on-Android.patch is applied twice for the android-armv7 build.

I think both are good points. I think I've addressed them in bug_27210_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27210_v3&id=f4b5f7b3b38679456d97b71904b0c59d4e4600d9) (together with a stupid typo).

comment:15 Changed 6 months ago by gk

Keywords: TorBrowserTeam201903R added; TorBrowserTeam201902R removed

February is gone.

comment:16 in reply to:  14 Changed 6 months ago by boklm

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

I think both are good points. I think I've addressed them in bug_27210_v3 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_27210_v3&id=f4b5f7b3b38679456d97b71904b0c59d4e4600d9) (together with a stupid typo).

This looks good to me. I merged this to master with commit ba9064e4b5a369b9c70201e335ef706db25f2815.

In the merge I fixed a conflict in projects/orbot/build: the patch was changing some lines which have been removed by #29633.

Note: See TracTickets for help on using tickets.