Changes between Version 2 and Version 3 of Ticket #27244, comment 9


Ignore:
Timestamp:
Sep 11, 2018, 10:50:43 PM (11 months ago)
Author:
cyberpunks
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27244, comment 9

    v2 v3  
    44This will read past the end of the mmap into invalid memory. It's missing some changes that are in the branch parselen1-on-ticket27247 (rebased on #27247 obviously).
    55
    6 Conversely, that branch was missing another mmap usage added in yours.
     6Conversely, that branch was missing another mmap usage added in yours. (Added now.)
     7
     8It looks like there are unrelated test fixups in the `Stop memcpy'ing uncompressed consensuses when making diffs` commit?
     9
     10Github also seems to be [https://github.com/torproject/tor/pull/316/commits wrongly showing] the commit `Replace "read consensus from disk" with "map consensus from disk".` as being before `Revise networkstatus parsing code to use lengths`, when [https://gitweb.torproject.org/nickm/tor.git/log/?h=networkstatus_mmap tpo] shows the opposite.